refactor: shared naca_core package - #5
Merged
Filettus-newkeyboard merged 2 commits intoSep 22, 2026
Merged
Conversation
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
naca_core/package with the modules that were duplicated ininhouse_core/andxfoil_core/: airfoil, panel_method, plotting, pre_run_checks, xfoil.run.py:inhouse_potential_optimizer/inhouse_optimizer.pyandxfoil_viscous_optimizer/xfoil_optimizer.py.pre_run_checkswithperform_all_checks(require_xfoil=...). XFOIL is still searched for (and downloaded to)xfoil_viscous_optimizer/.xfoil_core).Commits
Verified
python tests/baseline_check.py: 24/24 match.Not changed
No numerical or terminal-output changes. Known bugs (.dat line breaks, SVG format, XFOIL messages inside the table, ...) are fixed in the next PR.
After merging
Your local
inhouse_core/andxfoil_core/folders may remain with only__pycache__inside: they are ignored by git and can be deleted.Depends on
#4 (base branch:
test/numerical-baseline).