Repository navigation
Controller texts in French, Italian and Swedish - #789
Merged
Merged
Conversation
The Steam Controller and global controller texts from #731 were English in fr, it and sv. They are translated now. The French test lists the Steam names that stay as they are.
Contributor
|
Thanks @v0lumehi, the Italian reads well and matches the rest of it.json ("pulsante", "assegnazione", "Croce direzionale", "Disattivato"; "Accesso rapido", "trackpad" and "Controlli di movimento" are what Steam and Nintendo use in Italian). LGTM with two small suggestions:
|
Contributor
|
Thanks @v0lumehi. I read the Italian next to the English, and most of it reads well. I agree with both of @Dino0005's suggestions, and I have three more:
The other texts are fine as they are. |
Wilderness01
pushed a commit
to Wilderness01/NX2Apple
that referenced
this pull request
Nov 6, 2026
Dino0005
added a commit
to Dino0005/NX2Apple
that referenced
this pull request
Nov 7, 2026
Four controller texts of LNPANDY#789 were still the machine translation: - controls.steam.Guide: "Pulsante Steam", the name Valve's Italian pages use; "Guide" is not printed on the controller - controls.gameNote: keep "in-game" ("nel gioco") - controls.mapping, controls.savingDisabled: "pulsanti" instead of "controller", the dialog maps the controller's buttons, and the Mac texts call them "pulsanti" ("Disposizione dei pulsanti") None of them is in the shell, so its catalogs stay as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 6 tasks
thehobbit85
added a commit
that referenced
this pull request
Nov 7, 2026
it: review notes of #789 on the controller texts
Haseenesss
added a commit
to Haseenesss/NX2Apple
that referenced
this pull request
Nov 8, 2026
The launcher's Italian table reads frontend/l10n/it.json: the menus, the mapping, cloud saves, General and the options pages in Italian. The buttons are "pulsanti", as the Mac texts call them since the review notes of LNPANDY#789 (9f1a51a), and the rest uses the words the Italian file already has (controller, launcher, modalità desktop, trucchi, salvataggi nel cloud). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
What and why
#731 added the Steam Controller and global controller texts in English, German and Chinese. French, Italian and Swedish still showed English. This PR adds 26 keys to each of
fr.json,it.jsonandsv.json: the global and per-game controller notes, the mapping button, the save messages and the Steam Controller section. I recomputed the list againsten.jsonandde.json. These 26 are the only controller keys that were missing. The Steam namesSteam Controller (2026), L4, L5, R4 and R5 stay as they are.The fallback test in
ControllerPreferencesTestsnow checks thatfr,itandsvare translated.FrenchLocalizationTestslists the six Steam names that French keeps as English.A native reader should look at fr, it and sv before the release. I am not sure about these choices:
@zatteogit and @Dino0005 (Italian) and @Koshindai (French), you wrote earlier texts for the app. Could you read the new ones? A word for Swedish would help too.
Not part of this PR:
fr.jsonstill has nobuilder.*andmsg.builder*keys (8), andsv.jsonstill lacks 163 older keys (console.*,fail.*,dev.*,dep.*). They fall back to English. I can open an issue for them.Checked
cd frontend && swift test(766 tests, the French cognate test needed the six Steam names, fixed),cd frontend-ios && swift test,python3 tools/l10n_shell_catalogs.py --check,python3 -m unittest discover tools/tests,python3 -m unittest discover -s frontend-qt/tests.Screenshots
None, text only. No layout changed. Longer strings were not checked in the views.
Scope
dm/,scripts/,docs/,ref/) is added to the repository