[Dino0005]

Follow-up of #789, with the review notes left there.

Fix or feature

• Fix
• Feature

What and why

Four controller texts of #789 were still the machine translation, because the review notes there came after the merge:

Key	Before	After
controls.steam.Guide	Guide	Pulsante Steam
controls.gameNote	Condiviso con il menu del controller di questo gioco.	Condiviso con il menu del controller nel gioco.
controls.mapping	Assegnazione del controller…	Assegnazione dei pulsanti…
controls.savingDisabled	… l’assegnazione del suo controller.	… l’assegnazione dei suoi pulsanti.

• "Guide" is not printed on the controller, which shows the Steam logo, and Valve's Italian pages call it "pulsante Steam" (Steam Hardware: "tenere premuto il pulsante Steam").
• gameNote keeps the English "in-game".
• The mapping dialog maps the controller's buttons, so "pulsanti": the Mac texts call a controller button "pulsante" and keep "tasto" for the keyboard ("Disposizione dei pulsanti", controls.note "I tasti e i pulsanti del controller…").
• controls.saveFailed stays "Impossibile salvare…", the form of 34 error texts in it.json.

Only frontend/l10n/it.json changes (4 lines). None of these texts is in the shell, so python3 tools/l10n_shell_catalogs.py leaves its catalogs as they are.

Checked

• Tests: swift test --filter 'LocalizationRulesTests|ControllerPreferencesTests|FrenchLocalizationTests|LanguageListTests|ShellStrings' green, python3 -m unittest discover -s tools/tests -p 'test_l10n*' OK, python3 tools/l10n_shell_catalogs.py --check passes. The pre-push hook passed.
• Test for a fix: none, a wording change has no behavior to test.
• Visual QA: NX_LAUNCHER_CAPTURE_DIR=<dir> NX_LAUNCHER_CAPTURE_SETTINGS=<fixture launcher.json> NX_CAPTURE_LANG=it swift test --filter ControllerEditorCaptureTests before and after, nothing cut or wrapped differently.
• Run on a device or Mac: not run.

Screenshots

Before and after, both in Italian. The orange boxes mark the same places on both images.

1. Controller mapping (controller-mapping-before-marked.png, controller-mapping-after-marked.png): "nel gioco", "Pulsante Steam".

2. Launch options (launch-options-before-marked.png, launch-options-after-marked.png): "Assegnazione dei pulsanti…".

3. Saved choices disabled (maintainer verification) (controls.savingDisabled). These before/after captures render the actual controller view in Italian with only the temporary fixture game's DM_SAVED_CHOICES set to 0. Before is main at 66c3b632, after is this PR at 9f1a51a7. The complete explanation fits across two lines in both. Temporary test-harness edits were restored and no production code or user settings changed.

Maintainer validation: independent review passed. Both capture runs passed, shell catalogs are current, and the localization suite ran 16 tests with one skipped. All current-head CI checks are green. The CI-built app from run 42354622933 launched successfully, opened the launch-options and controller-mapping screens, returned to the library and quit normally. The hands-on app trial used the existing English setting, while the captures above verify the Italian wording.

Scope

• No engine file (dm/, scripts/, docs/, ref/) is added to the repository: a change there is a patch in patches/ (a commit in engine/, then tools/engine.py export, and tools/engine.py check passes), with its Upstream-Status
• A fix to the engine or a game profile also goes to seedds/nxnative as a PR in parallel: this PR's patch says forwarded seedds/nxnative#..., or pending until that PR is open
• A change to a launcher view has before and after screenshots above
• No keys, game files or data extracted from a game in the change or the attachments

[thehobbit85]

The four wording corrections match the follow-up discussion on #789, and the current checks pass. I checked the attached Italian mapping and launch-options captures.

The remaining visual-evidence gap is controls.savingDisabled, which the body correctly says is absent from the captures. Please add an Italian before/after capture of the controller editor with saved choices turned off, so the changed disabled-state explanation is visible as required by CONTRIBUTING.md. No additional wording change is requested.

Assigned v1.2.5 to follow the launcher/controller/language milestone and requested a full CI app build for the required maintainer trial. The previous app-build job was skipped, so it does not yet supply that trial artifact.

[thehobbit85]

Approved 9f1a51a. The four Italian wording changes match the #789 review discussion and independent review found no code issue. I generated, inspected and attached the missing real disabled-state before/after captures. The full message fits in both, so my earlier screenshot request is resolved. Only a temporary fixture was changed to obtain those captures, with no production commit or user-setting change.

Current-head CI is green. Maintainer trial of the app from build 42354622933 passed: launch, launch-options/controller editor navigation, return to library and normal quit. The live trial used the existing English setting, and the attached captures verify the Italian words. Both capture runs and the localization checks passed (16 tests, one skipped). Ready for a normal GitHub merge into the v1.2.5 milestone.