Skip to content

Fix failing rspec test by reading coverage data from coverage_data.js #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connorshea wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Fix failing rspec test by reading coverage data from coverage_data.js #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion spec/integration/runners/queue/rspec_runner_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2336,7 +2336,9 @@ def when_first_matching_example_defined(type:)

context 'when the RSpec split by test examples is enabled AND simplecov is used' do
let(:coverage_dir) { "#{KNAPSACK_PRO_TMP_DIR}/coverage" }
let(:coverage_file) { "#{coverage_dir}/index.html" }
# SimpleCov >= 1.0 renders index.html from data stored in coverage_data.js,
# so the covered files are listed there instead of in the HTML.
let(:coverage_file) { "#{coverage_dir}/coverage_data.js" }

before do
ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
Expand Down