Fix failing rspec test by reading coverage data from coverage_data.js#347
Open
connorshea wants to merge 1 commit into
Open
Fix failing rspec test by reading coverage data from coverage_data.js#347connorshea wants to merge 1 commit into
coverage_data.js#347connorshea wants to merge 1 commit into
Conversation
SimpleCov 1.0 rewrote its HTML formatter: index.html is now a static shell that loads a client-side viewer, and the report data lives in coverage_data.js. Point the integration test at that file so the assertions on the covered spec file paths match again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AI Disclosure: Had Claude investigate and fix the problem, verified it myself for correctness.
Fix the test failure caused by the simplecov version upgrade.
SimpleCov 1.0 rewrote its HTML formatter:
index.htmlis now static and loads a client-side viewer, and the report data lives incoverage_data.js. So we want to check that file instead.This is a test change so I don't think it makes sense to update the CHANGELOG?
Checks
UNRELEASEDsection of theCHANGELOG.md, including the needed bump (i.e., patch, minor, major)lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and E2E tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and E2E tested.