docs: enforce Promise.withResolvers() more explicitly. - #13600
Merged
Conversation
marius-kilocode
approved these changes
Aug 31, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by grok-4.6 · Input: 34.4K · Output: 3.6K · Cached: 165.1K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We keep seeing patterns like this:
as opposite of having just this:
which is more explicit and available since 2024 in all runtimes: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/withResolvers#browser_compatibility
Fixes #
Context
This MR makes the wording around preferring
Promise.withResolvers()more explicit, hoping that will lead to less LOC shipped for no reason with also flaky guards around (see bothresolve?andreject?instantly attached after so that these are a certainity, not a maybe).Implementation
The wording has been changed to explicitly avoid the mentioned case, hoping we won't see that pattern with runtime created no-ops around.