Repository navigation
fix(windows): 使用 Acrylic 控制器修复边缘模糊并保持失焦效果 - #1
Merged
Merged
Conversation
6 tasks done
|
This pull request changes 8265 source lines (limit 1500; docs, lockfiles and assets excluded). Changes this large cannot be reviewed reliably, so please split it into independent pull requests — one behaviour change each, with its own tests. 本 PR 改动 8265 行源码(上限 1500,不计文档、lockfile、资源)。这么大的改动无法可靠审查,请拆成多个相互独立的 PR,每个只做一件事并附测试。 Maintainers can add the |
…#133) Localize GPUI workspace controls, split actions, file panels, and close confirmations using existing typed messages and application language. Add 57 English/Chinese message entries and focused i18n regressions. Keep close confirmations in the existing closing lifecycle module. Retain the scoped contribution from PR Kuddev#133 without adding global language state, translation macros, or legacy-shell migrations.
Use pinned nextest for full native tests while retaining doctests, production-feature checks and both macOS release checks. Publish shared dependency snapshots from successful default-branch runs, keep compiled artifacts architecture-specific, and preserve cross-process exclusion for shared theme fixtures. Run the full platform matrix for both draft and ready pull requests without repeating it for readiness-only transitions.
Forward the current and legacy hook executable variables through WSLENV with /p path translation. Document the boundary contract and cover the primary hook variable in the existing environment test.
…ddev#293) Add opt-in off/smooth cursor-motion preferences with conservative defaults and reset support. Add GPUI-local motion trajectory contracts and synchronized-update snapshot regression coverage. Renderer and settings UI integration remain separate.
Complete the Traditional Chinese catalog and align Taiwan UI terminology. Preserve message IDs and placeholders, correct the search coverage wording, and label backup contents consistently.
Keep DECSET 2031 enable/re-enable silent while retaining reports for actual palette changes. Cover repeated subscriptions and byte boundaries. Fixes Kuddev#283.
…ws (Kuddev#234) Reanchor only uniquely matched content after complete synchronized Pi redraws. Preserve standard clearing and cancel stale anchors on user actions or interrupted updates. Related to Kuddev#159.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Windows 窗口贴近屏幕边缘时,原 Accent Acrylic 会透出未充分模糊的背景细节。本改动在受支持的系统上使用 DesktopAcrylicController 改善边缘,并显式配置失焦状态,避免切到其他窗口后变成不透明灰底。保留现有透明度、主题及窗口内容绘制,不增加边缘遮罩。最大化与还原到窗口的动画期间暂时清空 backdrop,避免旧模糊采样随窗口拉伸/裁切,随后恢复;普通移动、最小化到任务栏及从任务栏恢复保持原生材质行为。
这是 fork 内部验收 PR。启动空白和初始尺寸跳变不包含在本次改动中。
Design / 设计边界
platform/acrylic;gpui_shell/wallpaper.rs继续负责材质选择和每窗口更新门控。platform/acrylic门面,非 Windows 保持原有 GPUI 材质路径;Windows 原生验收测试与控制器生命周期同目录。architecture/notes/nebula_app/platform/2026-09-22-acrylic-controller.md及同目录2026-09-22-acrylic-window-transitions.md。Evidence / 验证依据
cargo build -p nebula --locked成功。cargo test -p nebula --bin pebrel --features gpui-test-support platform::acrylic:: --locked --offline -- --include-ignored --test-threads=1:4 项测试通过,覆盖缺失运行库、无效 HWND、双窗口资源、材质切换、ShowWindowAsync/系统命令、旧 queued timer、连续切换、任务栏最小化/恢复材质不变、最新 SDK brush 优先、HWND 先销毁以及队列退出。cargo test -p nebula --bin pebrel native_acrylic_gpui_material_switches_and_window_lifecycle -- --ignored --test-threads=1:1 项真实 GPUI 测试通过,覆盖五种材质切换、相同档位第二窗口、21 次透明度更新不重建、窗口关闭及正常应用退出。python scripts/check_architecture.py --base 3050374343f0b3b1821c38ffaedb3a75201b6355、git diff --check、cargo fmt --all -- --check --config newline_style=Auto通过。newline_style=Auto用于本机 CRLF checkout;未格式化无关文件。Required Review / 必须确认
CONTRIBUTING.md、docs/architecture.md和docs/project-constraints.md。这些本地结果不代替 CI 和维护者审查。
上游草稿 PR:https://github.com/Kuddev/pebrel/pull/250(关联上游 issue Kuddev#236 的 Acrylic 部分)。