Repository navigation
fix(startup): 后台准备图标并消除首次显示的尺寸跳变 - #2
Merged
Merged
Conversation
|
This pull request changes 7671 source lines (limit 1500; docs, lockfiles and assets excluded). Changes this large cannot be reviewed reliably, so please split it into independent pull requests — one behaviour change each, with its own tests. 本 PR 改动 7671 行源码(上限 1500,不计文档、lockfile、资源)。这么大的改动无法可靠审查,请拆成多个相互独立的 PR,每个只做一件事并附测试。 Maintainers can add the |
JoyElliot
marked this pull request as ready for review
September 26, 2026 02:07
…#133) Localize GPUI workspace controls, split actions, file panels, and close confirmations using existing typed messages and application language. Add 57 English/Chinese message entries and focused i18n regressions. Keep close confirmations in the existing closing lifecycle module. Retain the scoped contribution from PR Kuddev#133 without adding global language state, translation macros, or legacy-shell migrations.
Use pinned nextest for full native tests while retaining doctests, production-feature checks and both macOS release checks. Publish shared dependency snapshots from successful default-branch runs, keep compiled artifacts architecture-specific, and preserve cross-process exclusion for shared theme fixtures. Run the full platform matrix for both draft and ready pull requests without repeating it for readiness-only transitions.
Forward the current and legacy hook executable variables through WSLENV with /p path translation. Document the boundary contract and cover the primary hook variable in the existing environment test.
…ddev#293) Add opt-in off/smooth cursor-motion preferences with conservative defaults and reset support. Add GPUI-local motion trajectory contracts and synchronized-update snapshot regression coverage. Renderer and settings UI integration remain separate.
Complete the Traditional Chinese catalog and align Taiwan UI terminology. Preserve message IDs and placeholders, correct the search coverage wording, and label backup contents consistently.
Keep DECSET 2031 enable/re-enable silent while retaining reports for actual palette changes. Cover repeated subscriptions and byte boundaries. Fixes Kuddev#283.
…ws (Kuddev#234) Reanchor only uniquely matched content after complete synchronized Pi redraws. Preserve standard clearing and cancel stale anchors on user actions or interrupted updates. Related to Kuddev#159.
…dev#250) Use a supported installed Acrylic controller with owned window and runtime lifetimes. Retain the existing Accent fallback and pixel-opacity behavior. Addresses the Acrylic portion of Kuddev#236; the Aero issue remains open.
…ev#248) Restore configurable macOS Command aliases, preserve RenameTab rebinding and dispatch Command-Q through the normal quit path. Register Command aliases through the existing runtime platform entry without changing platform budgets or validation rules. Fixes Kuddev#238.
Use the existing opaque settings panel surface for the update dialog without changing terminal transparency or update actions. Cover the modal with light and dark themes, shell opacity values, and visible layout checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
修复 Windows 正常启动时先出现透明空窗口、随后扩展到终端目标尺寸的过程。创建 HWND 前计算首屏尺寸,图标解码与缩放移到后台;窗口完成首次呈现后才按原有焦点请求显示。首屏无需等待图标准备。
本 PR 仅包含启动修复。Acrylic 材质修复保留在 #1;
acrylic-startup-preview整合分支用于同时验证两项改动,不要求将两个 PR 合并为一个。Design / 设计边界
architecture/notes/nebula_app/gpui_shell/workspace/2026-09-22-nonblocking-first-frame.md。Evidence / 验证依据
cargo test -p nebula --bin pebrel --features gpui-test-support gpui_shell::workspace::logos:: --locked --offline -- --test-threads=1:3 passed,覆盖像素一致性、协作取消和已排队回填的取消,保留请求作为正常发布对照。cargo fmt --all --check -- --config newline_style=Auto、git diff --check、python scripts/check_architecture.py --base 3050374343f0b3b1821c38ffaedb3a75201b6355、python scripts/check_platform_cfg.py通过。Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.python scripts/check_architecture.py --base 3050374343f0b3b1821c38ffaedb3a75201b6355passes; budgets were not inflated to fit the change.上游草稿 PR:Kuddev#251