Skip to content

fix(deploy): drop alertClass, which deploy-kit 1.0 removes - #116

Merged
ExtraToast merged 1 commit into
mainfrom
fix/drop-alert-class
Oct 27, 2026
Merged

ExtraToast merged 1 commit into
mainfrom
fix/drop-alert-class

Conversation

@ExtraToast

Copy link
Copy Markdown
Contributor

Summary

Drops observability.alertClass from the project file. deploy-kit 1.0 removed the field (JorisJonkers-dev/deploy-kit#628): once the estate composes on 1.0, a fragment that still carries it is refused, and its Project is held at its last render. The field is optional on the toolkit this repository publishes with today, so this release is valid now, and publishing it ahead of the estate's move means the move doesn't have to wait for this repository.

To know:

Testing

  • With this change, every estate project file plus every Project's deploy/ on main validates on deploy-kit main: accepted (60 read).

Part of JorisJonkers-dev/deploy-kit#380.

@ExtraToast ExtraToast added type: bug Something is broken or behaving incorrectly. area: deploy homelab-deploy, deploy-v2, manifests, and rollout flow. labels Oct 27, 2026
@ExtraToast
ExtraToast enabled auto-merge (squash) October 27, 2026 11:01
@ExtraToast
ExtraToast merged commit 9be5ed8 into main Oct 27, 2026
10 checks passed
ExtraToast added a commit that referenced this pull request Oct 27, 2026
This reverts commit 9be5ed8 (#116). On the toolkit fragments publish with today (0.31, and 0.32 too) observability.alertClass is required, so without it the next release's fragment would be refused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: deploy homelab-deploy, deploy-v2, manifests, and rollout flow. type: bug Something is broken or behaving incorrectly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant