Repository navigation
revert: keep alertClass until the toolkit is deploy-kit 1.0 - #118
Merged
Merged
Conversation
ExtraToast
added
type: bug
ExtraToast
enabled auto-merge (squash)
October 27, 2026 11:05
4 tasks
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #116. I was wrong that
observability.alertClassis optional before deploy-kit 1.0: on 0.31 and 0.32, anobservabilityblock requires it. Without it, auth-api's next release would fail to publish its fragment.alertClass: pageis back on theauthApplication.${identity:vaultRole}, once the shared Publish Fragment workflow runs 1.0.Testing
deploy-kit validateon 0.20.0 and on 0.32.0 withalertClass: Invalid option: expected one of "business-hours"|"urgent"|"page". Its CI runs that check; auth-api's has no such check, which is why fix(deploy): drop alertClass, which deploy-kit 1.0 removes #116 merged green.