Repository navigation
Complete configurable selection feedback across clients (#120) - #341
Merged
Merged
Conversation
Show Likely next suggestions above Typing controls with the keyboard (#213)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes #120's selection feedback. Screens and the Typing Screen now share one Android timer; the compact Phrase row also shows feedback. Selection uses static inset black/white rings, leaving focus and dwell feedback visible. Desktop adds the same feedback and a persisted duration under Settings > Access, with 0 disabling it. iOS gets the ring and timer corrections.
Closes #120. Stacked on the #225 cleanup; merge that first.
Evidence
After: both UI tests pass, including selection alongside focus. Shared timing tests pass.
Merge Danger
Door: two-way
Blast Radius: feedback
No animation or schema migration. Desktop's JSON adds a defaulted duration field. iOS compilation and visual checks are the remaining validation limit.