Repository navigation
Show Likely next suggestions above Typing controls with the keyboard (#213) - #342
Merged
Jdreioe merged 1 commit intoOct 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the requested Likely next row above Typing's existing controls while the on-screen keyboard is visible.
Uses the existing experiment setting and in-memory History ranking. Suggestions are read-only and use the History Page's insertion/speech behavior. The row hides when History is hidden, unavailable or empty. Changing History visibility or returning from Settings discards cached suggestions before refreshing. English and Danish setting descriptions now cover both the Page and row.
Refs #213. The keep/promote/delete experiment decision remains open. Stacked on #341; merge #340, then #341, then this PR, retargeting each as its base merges.
Evidence
After: emulator UI test verifies the keyboard-only row, read-only semantics, tap action, visibility gates, and retention of the existing saved-Phrase controls and composed Message.
source=likely_nextmetadata without text, and clearing/refusing disabled suggestions.Merge Danger
Door: two-way
Blast Radius: Typing
Android-only follow-up. Off by default with the existing experimental setting. Landscape uses a shorter row to leave room for the Message and action controls.