Skip to content

Show Likely next suggestions above Typing controls with the keyboard (#213) - #342

Merged
Jdreioe merged 1 commit into
fix/120-selection-feedbackfrom
feat/213-typing-suggestion-row
Oct 23, 2026
Merged

Jdreioe merged 1 commit into
fix/120-selection-feedbackfrom
feat/213-typing-suggestion-row

Conversation

@Jdreioe

@Jdreioe Jdreioe commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Summary

Adds the requested Likely next row above Typing's existing controls while the on-screen keyboard is visible.

Likely next Messages, first 4 ranked suggestions
Existing Typing controls and saved Phrases
Message
On-screen keyboard

Uses the existing experiment setting and in-memory History ranking. Suggestions are read-only and use the History Page's insertion/speech behavior. The row hides when History is hidden, unavailable or empty. Changing History visibility or returning from Settings discards cached suggestions before refreshing. English and Danish setting descriptions now cover both the Page and row.

Refs #213. The keep/promote/delete experiment decision remains open. Stacked on #341; merge #340, then #341, then this PR, retargeting each as its base merges.

Evidence

  • Before: Likely next was available only on a Typing Screen Page.
    After: emulator UI test verifies the keyboard-only row, read-only semantics, tap action, visibility gates, and retention of the existing saved-Phrase controls and composed Message.
  • 25 Typing ViewModel tests pass, including bounded suggestions, existing activation policy, source=likely_next metadata without text, and clearing/refusing disabled suggestions.
  • Existing Typing content tests pass. Keyboard visibility tests pass, including native keyboard retraction with animations enabled and Gboard selected on the disposable emulator.
  • Existing shared ranking is unchanged; no new persistent data or dependencies.

Merge Danger

Door: two-way

Blast Radius: Typing

Android-only follow-up. Off by default with the existing experimental setting. Landscape uses a shorter row to leave room for the Message and action controls.

@Jdreioe
Jdreioe merged commit 508e851 into fix/120-selection-feedback Oct 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant