Repository navigation
Conversation
Add an implementation-bound reference for result provenance, deterministic seed comparison, complete evaluated-trial history and future trace-bound ranking calibration in the existing knowledge owners. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
Retain valid duplicate history rows in the Infera source explanation and separate signature-based future evaluation skips from loading the ledger. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
Build the native catalog and coverage from the corrected canonical source revision while preserving all existing owners and source records. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Skill evaluationPLANNED: not executed; there are no task outcomes yet.
Author verification steps (nonpaid; not yet run)
python tools/build_skill_index.py --source-revision f8a7e832feab05f8262ebe4057f34e2c8a48fd95 --checkThe declared source pin matches this head's canonical library bytes. The command has not run: retain its exit code and full drift/success output. It checks the generated projection, not claim truth or skill efficacy.
python -m json.tool optimization-search-policy/plan/tasks.json
python -m json.tool optimization-search-policy/plan/schema.jsonUncovered scope by location: Canonical library paths: 4; Generated projection paths: 80; Other paths: 3. Path counts are not claim counts; no metadata-only conclusion is inferred. Evidence and logs · Retention: 30 days. Plan bindings, budget, frozen exam and advisory detailsAdvisory: obtain missing evidenceRetained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
Model/settings:
Frozen exam hashes: Selection/task metadata (not a relevance verdict): {"adapter":"kv-admission-diagnostic-v1","basis":"trusted_path_mapping","matched_paths":["src/inferrsi/data/skill_library/methods/optimization-search-policy/SKILL.md","src/inferrsi/data/skill_library/methods/optimization-search-policy/metadata.json"],"required_answer_fields":["diagnosis","evidence","next_check","reuse_authorized"],"tasks":[{"id":"case-05","provenance":"Synthetic finite-state observations; not a production trace or engine benchmark.","request":"Diagnose this blocked request at the recorded decision boundary; propose the next read-only check.","split":"holdout"}]}Automatic execution / cumulative PR budget: {"reason":"Trusted configuration or pricing missing, invalid or expired","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}Projection check selection (not an executed result): {"declared_in":"src/inferrsi/data/repo_packs/inferrsi/knowledge/README.md","source_revision":"f8a7e832feab05f8262ebe4057f34e2c8a48fd95","status":"ready"}Provider/settings: Uncovered / unsupported paths (87)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16a296585e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Original source / version | Inspected scope and local evidence | Mechanism / consumer | Evidence limits | | ||
| |---|---|---|---| | ||
| | Vidur — [2405.05465v2](https://arxiv.org/abs/2405.05465v2) | [A readset](../src/inferrsi/data/skill_library/methods/performance-ceiling-analysis/references/papers-20261015/READSET.md); §§3–7, A.1–A.2 | mined — operator/queue model calibration and joint-SLO shortlist → [calibrate-serving-simulation](../src/inferrsi/data/skill_library/methods/calibrate-serving-simulation/SKILL.md), ceiling analysis | Empirical prediction, not physical bound; near-capacity CPU overhead and 12.65% maximum error in the specified appendix case; no current runtime calibration | | ||
| | [AMD Infera @ ff1136e4](https://github.com/AMD-AGI/Infera/tree/ff1136e4a51998eba2933ed63cfb9c10120f86ea) | Direct bounded source inspection, 2026-11-03: serving CLI/evaluator/history, seed/objective parser, launcher/DES countercheck and named unexecuted test definitions; [16-path readset and rights](../src/inferrsi/data/skill_library/methods/calibrate-serving-simulation/references/infera-serving-search/source-record.json) | mined — one [calibration-owned provenance reference](../src/inferrsi/data/skill_library/methods/calibrate-serving-simulation/references/infera-serving-search/README.md); search-policy links its seed comparator and evaluated-trial ledger | Source-derived candidate; empirical not_run. Scalar tuner scoring and DES percentiles are separate; missing SLO fields and stale no-P/D-queues text are qualified. Selected original paths MIT; no runtime, ranking accuracy, quality, service or agent-benefit result. | |
There was a problem hiding this comment.
When generating the coverage view, tools/build_skill_coverage.py::references() recognizes owners only through backticked registered IDs or links to /SKILL.md. This row has neither: its local links target resource files, so the builder associates Infera with no skill. Consequently, the regenerated docs/skill-coverage.md still lists Vidur as the calibration skill's only mapped source, omitting the new Infera provenance. Include a backticked calibrate-serving-simulation mention or a link to its skill entry and regenerate the coverage view.
AGENTS.md reference: AGENTS.md:L100-L100
Useful? React with 👍 / 👎.
Name the existing registered calibration owner in the reference matrix so native coverage retains the Infera source mapping. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
Dong1017
added
the
area:knowledge
ChatGPT Codex Connector
Generate native projections from actual corrected canonical source f8a7e83. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
|
This docs-only PR adds an owner-local Infera serving-search provenance reference under Reviewed commit: 0a215de |
agent-ci-infra-bot
Bot
added
bot-reviewed
kind:docs
|
Review at head
Not verified by me: the upstream source pins in |
|
@amy-why-3459 @zengchuang-hw, could you please independently review this PR at To address the cross-PR integration concern, I propose merging this PR first, followed by #322, #324, #325, #339 and #342, subject to each PR's current reviews and checks. After each predecessor lands, we will preserve the combined canonical sources, regenerate the shared index and coverage from the actual source revision, and revalidate the next head before requesting its review. Please also let us know if you suggest a different order. Source and software checks do not establish model, device, or effectiveness results. |
|
Thanks for the review request and proposed order. I did a Codex-assisted, non-voting integration check of
The current head is awaiting formal independent approvals. |
Refs #91. Refs #177.
Problem and scope
An Infera result labeled
source="inference"can represent dry, analytical or anchor-assisted paths. Its best-summary output, retained history and scalar SLO checks also describe different evidence. This source-only amendment adds one implementation-bound reference to the existingcalibrate-serving-simulationowner and a short route fromoptimization-search-policy.The reference distinguishes measured anchors from target projections, a deterministic seed sweep from an LLM continuation, retained evaluated rows from future duplicate-evaluation skips, and the scalar parser from the separate DES percentile report. It preserves missing/unknown SLO-field limits and the code/documentation disagreement about split P/D queues. Trace-bound ranking calibration is an explicitly proposed independent study, with no supplied runner, calibration result or service guarantee.
Eight canonical paths contain two owner-local references, the two existing owner route/metadata pairs and the two matrix mappings. Existing Vidur knowledge and generic search rules remain intact. No registered skill, engine, planner, runtime, schema or experiment implementation is added.
Fixed source and provenance
ff1136e4a51998eba2933ed63cfb9c10120f86ea, tree7ca812406c61b52452270c4c8c53d1582d510376.d4a1922a452ed5b10f4cbd303d4f1d90e871f4b9and corrected M2fe3891c8db8c0fe38c8d5fd97b287ba19de82cf9over main663f3b327998526a13aa31e72ad729025c18983c. Actual canonical M3f8a7e832feab05f8262ebe4057f34e2c8a48fd95adds the existing calibration owner ID to the reference-matrix row so the original coverage parser attributes Infera correctly. Native G/H0a215de89a7cd9023d022fd5e9f4d943ef5ebf99was generated only after real M3. All eight canonical files remain unchanged in G/H; 81 native projection files retain existing owners, source records, matrices and registry.Validation and limits
The fixed source/readset and rights were grounded before construction. Independent private gpt-6.1-sol / ultra source review passed corrected M2, including retained duplicate history rows versus future evaluation skips, and separately passed the minimal M3 owner-mapping correction against the original parser contract. The reviewer is review-only.
Both original native write modes passed at actual M3. At final H, the original index check reported 79 current metadata records and the original coverage check matched its sources; both returned zero. The coverage row now attributes both Vidur and Infera to the existing calibration owner.
Real current-H native owner/catalog and resource readers passed for both affected owners. Checkout bundles contained 5 calibration resources and 26 search resources; each source-package bundle contained 757 resources. Complete bundle bytes, hashes, required resources and exact revisions were verified. Fourteen revision-bound resource API reads covered the two new references, owner/package entry points and cross-owner routes. Whole-resource Collect returned both requested owners for both adapters with complete manifests, matching entrypoint material and no omissions. Source-package reads use the checkout and are separate from wheel evidence.
Ready 41626479226 passed all six jobs. Python 3.10 and 3.11 full checks each reported 3,544 passed / 13 skipped / 1 warning / 284 subtests, plus Ruff. Both fresh isolated noneditable wheels loaded 127 source-grounded records from site-packages outside the checkout and verified the declared source resources, including both new references. The actual tested merge
8422a362cf019819c65d43073eda003f8d36e6e9, with main663f3b32and this H as parents, has exactly this H tree.Independent private gpt-6.1-sol / ultra review covered the complete final H, fixed source interpretation, the M3 correction, all native projections, actual readers and current CI/wheel evidence: LGTM, with no findings. The reviewer is review-only. Current-H Codex review completed without findings or unresolved flags. The previous owner-mapping thread remains unmodified and outdated; its source issue is corrected and independently verified. Current PR checks report the final head-bound declaration result.
Earlier M1 outputs, pre-H checks, H
16a29658software results and the interrupted expanded historical-resource reader attempt remain separate historical evidence. They are not substituted for the final-H checks above. No SkillEval comparison or model call was executed; unsupported paths supply no efficacy result.Knowledge remains candidate/not_run and efficacy remains not_evaluated. Source test definitions were inspected, not run. No upstream import/build/test/CLI, model/device/service execution, ranking calibration, agent comparison or paid trial was performed. Software and source consistency do not establish measured optimization benefit.
Knowledge authorship declaration