Repository navigation
Conversation
Extend the existing benchmark-design owner with fixed-source coupled-state, accepted-prefix and completion-denominator validation guidance. Retain source-only candidate boundaries and the historical report's distinct execution revision. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex (gpt-6.1-sol, reasoning_effort=max)
Regenerate coverage and packaged skill discovery from actual source d356da0. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex (gpt-6.1-sol, reasoning_effort=max)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Skill evaluationPLANNED: not executed; there are no task outcomes yet.
Author verification steps (nonpaid; not yet run)
python tools/build_skill_index.py --source-revision bad68ff5c1426b050df78ffbd106ac2e370ce186 --checkThe declared source pin matches this head's canonical library bytes. The command has not run: retain its exit code and full drift/success output. It checks the generated projection, not claim truth or skill efficacy.
Evidence and logs · Retention: 30 days. Plan bindings, budget, frozen exam and advisory detailsAdvisory: obtain missing evidenceRetained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
Model/settings:
Selection/task metadata (not a relevance verdict): {"adapter":"audit","basis":"trusted_path_mapping","matched_paths":["src/inferrsi/data/skill_library/methods/inference-benchmark-design/SKILL.md","src/inferrsi/data/skill_library/methods/inference-benchmark-design/metadata.json","src/inferrsi/data/skill_library/methods/inference-benchmark-design/references/ninfer-source.json","src/inferrsi/data/skill_library/methods/inference-benchmark-design/references/ninfer-state-and-completion-contracts.md"],"tasks":[{"evidence_scope":"http_fixed_workload","id":"audit-threshold","request":"Audit the fixed input report using its contract. Compute the median of per-trial request means, including every request in each trial, and the percentage reduction relative to the baseline aggregate.","split":"holdout"}]}Automatic execution / cumulative PR budget: {"reason":"Trusted configuration or pricing missing, invalid or expired","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}Projection check selection (not an executed result): {"declared_in":"src/inferrsi/data/repo_packs/inferrsi/knowledge/README.md","source_revision":"bad68ff5c1426b050df78ffbd106ac2e370ce186","status":"ready"}Provider/settings: Uncovered / unsupported paths (87)
|
Retain original state and completion evidence with all current-main canonical, applicability, resource-layer and release additions before regenerating projections. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
Regenerate the native coverage and catalog from actual source M 7045a9e. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
Make the reference matrix source row attributable to the registered benchmark owner. Retain its hardware applicability exclusion and sources. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author)
Regenerate coverage and packaged skill discovery from actual source bad68ff. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex (gpt-6.1-sol, reasoning_effort=max)
|
This PR adds a NInfer source ledger and a state-restoration/completion-validation reference to the existing Reviewed commit: cbbee59 |
|
Review at head
Not verified by me: the upstream source pins in |
Refs #91. Refs #177.
Problem and scope
Zero accepted drafts does not mean zero adopted input, and a commit receipt does not establish device retirement. This source-only amendment adds a NInfer-specific state-restoration and completion-validation reference to the existing
inference-benchmark-designowner, with an ordinary source ledger, a short entry pointer, incremental metadata and the two matrix mappings.The reference identifies coupled StateImage/Main/MTP history, the same-physical-block fold oracle, frontend-adopted versus accepted/committed counts, and publication/retirement observations. It preserves cancellation, zero/mixed/full-prefix controls and historical phase/corpus/wave denominator differences. Existing speculative-budget and Ouro recurrent-KV owners retain their separate responsibilities. No engine, controller, runtime, schema, registered skill or test implementation is added.
Fixed source and provenance
1882c6adbc98043fcf89f3589aa5addb3742777a.7f6aafedb5f20200def820cfe51ab81c09c20eeb, not the inspected source revision, and retain their quality/termination gaps.d356da0b8e4697cd4f584c837d8cbbacac22c13eis retained through main-preserving integration M7045a9eef66e310b4810fbb7d2d9d25ed1d14b24over main663f3b327998526a13aa31e72ad729025c18983c. Corrective real source Mbad68ff5c1426b050df78ffbd106ac2e370ce186follows prior H1367f22dce62cd9bc72c32e7d2470e264d1283f4and adds the existing benchmark owner ID to the Reference Matrix row. Native G/H iscbbee590ec78c77ec15e4c169f80aeefa7ab671e, generated only after actual corrective M. Metadata, the Searchspace Matrix and the exact owner applicability exclusion remain unchanged, as do both original NInfer resources. All 81 native projections are regenerated from this actual M; pending Xe-Forge, DeepSeek and Infera increments are not imported. Future integration must preserve combined canonical sources and regenerate their projections.Validation status and limits
Both original native write modes passed from actual corrective M; the unmodified Reference Matrix parser now associates the NInfer row with the existing owner. No runtime, source interpretation, schema, generator or evaluator was changed.
Both original final-H checks passed with 79 current metadata records and matching coverage. Real native owner/catalog reads verified all 12 source-file manifest hashes; checkout returned 15 resources and the source-package adapter exposed 757 dependency resources. Whole-resource Collect selected all 15 resources (189,640 bytes), including both unchanged NInfer references, with no omissions and revision-bound byte/hash checks. The corrected Reference Matrix mapping is visible in the actual coverage output, and the exact main applicability exclusion is retained. Source-package reads use the checkout and are separate from installed-wheel evidence.
Ready 41636127211 passed all six jobs. Python 3.10 and 3.11 full checks each reported 3,544 passed / 13 skipped / 1 warning / 284 subtests, plus Ruff. Each fresh isolated noneditable wheel loaded 127 source-grounded records from site-packages outside the checkout and verified the declared resources. The actual tested merge
488124eb0e08f15eb65067986963d41cac224b82, with main663f3b32and this H as parents, has exactly this H tree.Private independent gpt-6.1-sol / ultra review covered the complete corrected H, source preservation, native projections, the owner mapping, actual readers and these current software/wheel results: LGTM, with no current-H findings. The reviewer is review-only. Current-H Codex review completed with no findings or unresolved flags; complete inline-thread reads returned zero threads. Current PR checks report the final head-bound declaration result. Earlier H
1367f22dresults remain historical; an earlier declaration failure on this H is also retained separately from the current corrected declaration result. A same-head SkillEval publication succeeded; the older concurrent publisher was subsequently refused by the anti-stale guard. These publication receipts are separate from trial outcomes.SkillEval selected 0 comparisons / 0 model calls and 87 unsupported paths, with the inherited executable-snapshot limitation retained. The original source/index check and source/content disposition provide their limited evidence; no evaluator, mapper, mode, producer or budget was changed and no efficacy result is claimed.
Knowledge remains candidate/not_run and efficacy remains not_evaluated. Upstream C++/CUDA/native assertions were read as definitions, not executed. No upstream build/test suite, model/device execution, service/quality experiment or paid trial was run. Software/source consistency does not establish native model parity, device performance or agent benefit.
Knowledge authorship declaration