Skip to content

Drop mpo(::OpSum) constructor and orphan path_indsnetwork helper #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfishman merged 1 commit into from
May 12, 2026
Merged

Drop mpo(::OpSum) constructor and orphan path_indsnetwork helper #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions docs/src/experimental_methods.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ Methods which still need to be discussed, modified, or deprecated.
TreeTensorNetwork(os::OpSum, sites::IndsNetwork; kws...)
```

* From `OpSum`, assuming path graph (`opsum_to_ttn.jl`):
```julia
mpo(os::OpSum, external_inds::Vector; kws...)
mpo(os::OpSum, s::IndsNetwork; kws...)
```

#### AbstractTreeTensorNetwork Type

* Required-to-implement abstract interface — `TreeTensorNetwork` provides both (`treetensornetworks/abstracttreetensornetwork.jl`):
Expand Down Expand Up @@ -243,13 +237,6 @@ Methods which still need to be discussed, modified, or deprecated.
IndsNetwork{V, I}(g::AbstractSimpleGraph, link_space::Dictionary, site_space::Dictionary)
```

* Build an `IndsNetwork` on a path graph from a vector of external (site) indices
per vertex, or one index per vertex (`indsnetwork.jl`):
```julia
path_indsnetwork(external_inds::Vector{<:Vector{<:Index}})
path_indsnetwork(external_inds::Vector{<:Index})
```

* Normalize a user-supplied link-space spec into a `Dictionary{edgetype, Vector{I}}`,
building fresh edge-tagged `Index` objects from raw integer dimensions when needed.
Accepts an integer, a `Vector{Int}`, a `Dictionary` of integers / vectors of integers /
Expand Down
15 changes: 0 additions & 15 deletions src/indsnetwork.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,21 +127,6 @@ function IndsNetwork{V, I}(
return IndsNetwork{V, I}(NamedGraph(g), link_space, site_space)
end

# Construct from collections of indices

function path_indsnetwork(external_inds::Vector{<:Vector{<:Index}})
g = named_path_graph(length(external_inds))
is = IndsNetwork(g)
for v in eachindex(external_inds)
is[v] = external_inds[v]
end
return is
end

function path_indsnetwork(external_inds::Vector{<:Index})
return path_indsnetwork(map(i -> [i], external_inds))
end

@traitfn function default_link_space(V::Type, g::::IsUnderlyingGraph)
# TODO: Convert `g` to vertex type `V`
E = edgetype(g)
Expand Down
8 changes: 0 additions & 8 deletions src/treetensornetworks/opsum_to_ttn/opsum_to_ttn.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,14 +659,6 @@ function TreeTensorNetwork(
return ttn_svd(os, sites, root_vertex; kwargs...)
end

function mpo(os::OpSum, external_inds::Vector; kwargs...)
return TreeTensorNetwork(os, path_indsnetwork(external_inds); kwargs...)
end
function mpo(os::OpSum, s::IndsNetwork; kwargs...)
# TODO: Check it is a path graph.
return TreeTensorNetwork(os, s; kwargs...)
end

# Catch-all for leaf eltype specification
function TreeTensorNetwork(eltype::Type{<:Number}, os, sites::IndsNetwork; kwargs...)
return NDTensors.convert_scalartype(eltype, TreeTensorNetwork(os, sites; kwargs...))
Expand Down
Loading