Drop mpo(::OpSum) constructor and orphan path_indsnetwork helper#368
Merged
Conversation
The two `mpo` overloads in `src/treetensornetworks/opsum_to_ttn/opsum_to_ttn.jl` were trivial wrappers forwarding to `TreeTensorNetwork(os, ...)`. Zero callers in src/, test/, Tennis.jl, ITensorNetworksNext.jl, or TensorNetworkQuantumSimulator.jl. Continuation of #356's direction of dropping short-name dispatches in favor of the explicit `TreeTensorNetwork(::OpSum, ...)` constructor. `path_indsnetwork` was the only consumer of the `mpo(::OpSum, ::Vector)` form (built a path-graph `IndsNetwork` from a vector of site Indices); with `mpo` gone it has zero callers and is also removed. Docs trimmed: removed the matching `mpo` and `path_indsnetwork` entries from `docs/src/experimental_methods.md`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 76.39% 76.77% +0.37%
==========================================
Files 57 57
Lines 2644 2631 -13
==========================================
Hits 2020 2020
+ Misses 624 611 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mpo(::OpSum, ...)overloads insrc/treetensornetworks/opsum_to_ttn/opsum_to_ttn.jl. Both were trivial wrappers forwarding toTreeTensorNetwork(os, path_indsnetwork(external_inds))andTreeTensorNetwork(os, s). Zero callers insrc/,test/, Tennis.jl, ITensorNetworksNext.jl, or TensorNetworkQuantumSimulator.jl. Continuation of #356's direction of dropping short-name dispatches in favor of explicitTreeTensorNetwork(::OpSum, ...)constructors.path_indsnetwork(two overloads insrc/indsnetwork.jl) — only consumer was the deletedmpo(::OpSum, ::Vector)form, so it's orphaned.docs/src/experimental_methods.md.No version bump — substantive change accumulates against the existing
0.22.0-DEVprerelease.