HDNEXT-1967: port remaining v30 features to ionos-dev-v33

[printminion-co]

• Resolves: HDNEXT-1967 — port changes from the v30 release to subsequent versions

Depends on: IONOS-Productivity/nc-richdocuments#14 — must be merged first, the apps-external/richdocuments gitlink in this PR points at its commit.

Summary

ionos-dev-v33 was rebuilt as a ground slate off vanilla v33.0.6 (HDNEXT-1604) with a hand-curated set of IONOS patches — 39 changed paths against 60 on ionos-dev-v30. Most of that difference is legitimate (patches that landed upstream in NC33), but a handful of IONOS features were lost in the reconstruction, including one runtime fatal.

Gap list derived by diffing each branch against its own vanilla base (v30.0.7..ionos-dev-v30 vs v33.0.6..ionos-dev-v33), then checking every v30-only patch against vanilla v33.0.6 to separate upstreamed from lost, plus a cherry-pick-aware comparison of all 13 submodules.

What this PR restores

Commit	Gap	Note
IONOS(auth)	UserAgentForbidden exception class was missing entirely	runtime fatal
IONOS(files-sharing)	Pending-shares view gate	backend was there, frontend consumer lost
IONOS(files)	computed templates_enabled	upstream regression
IONOS(files)	admin-configurable files user-config defaults
IONOS(settings)	null mail transport notice	upstream branch was unreachable
IONOS(config)	IONOS gitlink → 01b3f0f	notify_push only with Redis
IONOS(richdocuments)	gitlink → guest gating fix	see linked PR

Each commit body names the original commit(s) it was ported from.

1. UserAgentForbidden — runtime fatal

lib/private/User/Session.php and ocs/v1.php both reference OC\Authentication\Exceptions\UserAgentForbidden, but the class file exists in neither this branch nor vanilla v33.0.6.

This is not theoretical: nc-config ships ionos-apps-user-agents.config.php with core.login_flow_v2.allowed_user_agents = ['/Hidrive Next/i'], so the allow-list is active on every IONOS instance. Reproduced:

Error: Class "OC\Authentication\Exceptions\UserAgentForbidden" not found at lib/private/User/Session.php#598

The request returns an empty 200 instead of the intended 403.

2. Pending shares — half-ported

LoadAdditionalListener already provides the accept_default initial state from sharing.enable_share_accept, but nothing consumed it, so Pending shares always showed. Upstream moved the file src/views/shares.ts → src/files_views/shares.ts; the gate is restored there, defaulting to false so it fails closed.

3. templates_enabled — upstream regression

Upstream 64e852c5906 replaced the computed value with a hardcoded true, removing the only way to hide Create templates folder. nc-config sets both skeletondirectory and templatedirectory to '', so the entry came back.

Restored, but using the same SERVERROOT defaults as TemplateManager::initializeTemplateDirectory() rather than v30's empty-string defaults, so an instance that configures neither value keeps upstream behaviour. For IONOS builds both are set explicitly, so the outcome is identical to v30.

4. UserConfig — deviates from v30 on purpose

v30 always used getAppValueBool(), safe because every ALLOWED_CONFIGS entry was a boolean back then. NC33 added default_view (string, files/personal), and coercing that through getAppValueBool() would return true instead of 'files' for every user without a stored preference. The fallback is therefore type-aware.

5. Mail settings — upstream branch was dead code

additional-mail.php is now just a Vue mount point, so v30's patch had nowhere to apply. The Vue view does carry the equivalent branch, but it can never fire:

<NcNoteCard v-if="smtpMode?.id === 'null'">

smtpMode resolves mail_smtpmode against smtpModeOptions, and Admin\Mail::getForm() only ever offers smtp/sendmail/qmail. With mail_smtpmode = 'null' the lookup yields undefined, the notice is skipped and the v-else form renders instead — with an empty Send mode select. Verified: smtpModeOptions ids were smtp while mail_smtpmode was null.

Since nc-config ships mail.config.php with mail_smtpmode = 'null', this page is broken on every IONOS instance today.

Deliberately out of scope

Test backports (UserConfigTest.php, LoadAdditionalListenerTest.php, SessionTest.php user-agent cases) and the FilesListVirtual.vue folder-icon tweak (tied to the dropped FA Pro icon set, HDNEXT-1719). apps/files/js/fileactionsmenu.js needs nothing — the file no longer exists in NC33.

Already upstreamed into NC33, so no work needed: SetConfig sensitive values, MountPoint, Preview\Movie S3 guard, Mailer NullTransport, LoginFlowV2 client allow-list, SearchComposer provider filtering, Template::findTemplate core fix, all config.sample.php doc changes.

How it was verified

All in the dev container.

• UserAgentForbidden: OCS + basic auth with a disallowed UA → 403 Client not allowed; allowed UA → 100 OK. Confirmed the failure mode without the fix, and that it works with the committed autoloader (OC\ resolves via PSR-4 — no classmap regeneration needed). Note WebDAV does not go through this path (own Sabre backend); pre-existing.
• UserConfig: types preserved (default_view stays a string), admin-set app value becomes the default for users without a preference, a user's own preference still wins, invalid values still rejected.
• Mail settings: initial state inspected to prove the upstream condition was unreachable; rebuilt bundle now uses the working gate.
• richdocuments: 4 creators registered for a guest while userCanEdit() was false; new test fails without the fix; suite 89 tests, 208 assertions green.
• phpunit: apps/files/tests/Controller/, apps/files_sharing/tests/Listener/, tests/lib/User/SessionTest.php → 65/65 and 32/32 green.
• cs:check / eslint: clean on all changed files. Two cs:check findings and 14 eslint errors were left alone — verified pre-existing (the cs ones exist verbatim in pristine v33.0.6; the eslint ones are in SidebarQuota.vue / SharesMixin.js).

Compiled dist/ assets for the two frontend changes are committed alongside their sources; unrelated build drift in other bundles was deliberately excluded.

TODO

• Merge IONOS: fix: do not offer document creation to public share visitors nc-richdocuments#14 first
• Re-confirm the apps-external/richdocuments gitlink points at the merged commit (rebase the bump if the PR is squash-merged)

Checklist

• Code is properly formatted
• Tests are included — see out of scope; the richdocuments PR carries a regression test
• Screenshots before/after for front-end changes
• Documentation has been updated or is not required