IONOS: fix: do not offer document creation to public share visitors

[printminion-co]

Part of HDNEXT-1967 — porting features from the v30 release to ionos-stable33 / ionos-dev-v33.

Blocks: IONOS-Productivity/nc-server#300 — that PR carries the apps-external/richdocuments gitlink bump pointing at this branch's commit, so this needs to merge first.

Summary

deab95d3e added the userCanEdit() gate to RegisterTemplateFileCreatorListener, but the guard is skipped when there is no logged-in user:

$user = $this->permissionManager->loggedInUser();
$userCanCreate = $this->permissionManager->isEnabledForUser($user) && $this->permissionManager->userCanEdit($user);
if ($user && !$userCanCreate) {   // <-- $user is null on a public share
    return;
}

loggedInUser() returns null on a public share link, so the early return never happens and all four Collabora creation entries get registered for anonymous visitors. DefaultPublicShareTemplateProvider calls listCreators() when rendering a public share, so this reaches the public share page.

Both group checks already report false without a user, so dropping the $user && condition is enough. Behaviour for logged-in users is unchanged.

Why this is needed for the v33 line

ionos-dev-v30 blocked this in src/public.js by only registering the legacy OCA.Files.NewFileMenu plugin when the current user was in edit_groups — for a guest getCurrentUser() is null, so the menu stayed away:

f1db58f79 IONOS: fix: for shares allow document creation only for users that can edit

That plugin and src/view/NewFileMenu.js no longer exist in the NC33 line, so the same product behaviour is restored where creation entries now come from.

How it was verified

Reproduced against the dev instance before fixing — with capabilities present and no user session, 4 creators were registered while userCanEdit() reported false.

• New test testHandleDoesNotRegisterForPublicShareVisitor — confirmed it fails without the one-line fix (not a vacuous test) and passes with it
• Full unit suite green: 89 tests, 208 assertions

Checklist

• Code is properly formatted
• Tests are included
• Screenshots before/after for front-end changes — n/a, backend gate only
• Documentation not required