Skip to content

Conversation

@beckyjackson
Copy link
Collaborator

This still gets a little hung up checking molecule, but it takes 45s to validate everything compared to the ~30 minutes that it was taking ROBOT.

The rules were copied from the original ROBOT validation rules. I had to add some imported terms to external to be able to reference them without VALVE complaining, and I added some of the external terms to core when they have MRO parents (so we don't have to have interdependent tables).

@beckyjackson
Copy link
Collaborator Author

beckyjackson commented Nov 5, 2020

TODO:

  • add regex patterns for labels to datatype.tsv
  • add checks for restriction levels
  • check index table for distinct IDs
  • replace current validate_template scripts with this

@beckyjackson beckyjackson marked this pull request as draft November 6, 2020 16:08
@jamesaoverton jamesaoverton removed their request for review November 19, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants