Repository navigation
docs(vault): rotate help matches the no-reseal refusal - #117
Merged
Merged
Conversation
`--drop-recipient` help, the `--yes` refusal text and the rotate summary still implied a dropped recipient keeps reading old objects without `--reseal`. Since a vault that holds entries now requires `--reseal`, that incomplete-revocation case only applies to empty vaults; say so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up review nits for #115 (merged).
N-1: rotate help and messages
The
--drop-recipienthelp, the--yesrefusal text and the rotate summary still implied that a dropped recipient keeps reading old objects without--reseal. Since #115, a vault that holds entries refuses a drop without--reseal. Incomplete revocation (the former recipient keeps its old-epoch wrap) now only applies to empty vaults. The text now says that. TheRotatedoc comment was also reflowed. No behaviour change. CHANGELOGUnreleasedline added.N-2: tracked hardening, not in this PR
This is pre-existing: there is no vault lock. That leaves a TOCTOU window between the no-reseal "vault holds entries" check in
cmd/vault.rs(~L349) and the rotation commit. The same window exists around the old-recipients snapshot check (~L617). A concurrent writer could add an entry after the check. The fix is a vault-level lock, which is tracked as separate hardening and not implemented here.