Skip to content

docs(vault): rotate help matches the no-reseal refusal - #117

Merged
VirtualMachinist merged 1 commit into
mainfrom
jupi/geode-115-nits
Oct 26, 2026
Merged

VirtualMachinist merged 1 commit into
mainfrom
jupi/geode-115-nits

Conversation

@VirtualMachinist

Copy link
Copy Markdown
Member

Follow-up review nits for #115 (merged).

N-1: rotate help and messages

The --drop-recipient help, the --yes refusal text and the rotate summary still implied that a dropped recipient keeps reading old objects without --reseal. Since #115, a vault that holds entries refuses a drop without --reseal. Incomplete revocation (the former recipient keeps its old-epoch wrap) now only applies to empty vaults. The text now says that. The Rotate doc comment was also reflowed. No behaviour change. CHANGELOG Unreleased line added.

N-2: tracked hardening, not in this PR

This is pre-existing: there is no vault lock. That leaves a TOCTOU window between the no-reseal "vault holds entries" check in cmd/vault.rs (~L349) and the rotation commit. The same window exists around the old-recipients snapshot check (~L617). A concurrent writer could add an entry after the check. The fix is a vault-level lock, which is tracked as separate hardening and not implemented here.

`--drop-recipient` help, the `--yes` refusal text and the rotate summary
still implied a dropped recipient keeps reading old objects without
`--reseal`. Since a vault that holds entries now requires `--reseal`, that
incomplete-revocation case only applies to empty vaults; say so.
@VirtualMachinist
VirtualMachinist marked this pull request as ready for review October 26, 2026 21:25
@VirtualMachinist
VirtualMachinist merged commit 1902cc2 into main Oct 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant