Repository navigation
docs(core): rotate callers must reseal a vault that holds entries - #118
Merged
Merged
Conversation
`commit_rotation` lays down an empty new-epoch manifest, so a rotation without reseal on a vault with entries hides them from the current epoch. State that requirement in the `rotate` module docs, on `commit_rotation` and in the crate overview. Docs only.
VirtualMachinist
marked this pull request as ready for review
October 27, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only follow-up from review of #115/#117.
commit_rotationlays down an empty new-epoch manifest. A caller that rotates without reseal on a vault that holds entries hides those entries from the current epoch (the CLI now refuses this). The core docs now state the requirement in one sentence each:rotatemodule docs (rotate.rs, "Rotate (no reseal)" section)commit_rotationdoc commentlib.rsNo code or behaviour change.