[Hafeok]

Completes: #209

What this changes, and why

Step 2 of the "issues are the work log" session, for #209, with the addition posted there before it was built. It is stacked on #259, whose AGENTS.md section it documents in, so it lands after #259. Until then its diff includes #259's four commits; its own are the last three.

• eng/land.cs -- N, before a push:
  • it lists every issue a Closes, Fixes or Resolves #N trailer line in main..head closes, with its title. A trailer is recognised exactly as eng/issue-refs.cs recognises one;
  • it refuses a pull request whose Completes: line is missing, duplicated or malformed, or names an issue no pushed trailer closes;
  • text inside HTML comments doesn't count, so the template's guidance can't satisfy the check;
  • a release descriptor's own trailer counts;
  • a body it can't read is refused (exit 2), not skipped;
  • a --commit landing has no pull request, so it is only listed.
• eng/land.cs -- N --main, after main has moved:
  • every issue a pushed trailer names must be closed. GitHub is asked again for up to a minute, because it closes issues a little after the push;
  • an issue still open is printed with its commit, and the exit is 1. GitHub unreadable is exit 2, and it says so;
  • it never closes anything.
• The PR template opens with Completes: none, and says what the line is and that it isn't a closing keyword (issue-refs: refuse closing keywords in pull request descriptions, not only in commits #108).
• AGENTS.md's Landing and After landing bullets name the line, the refusal and the check after landing.

What was measured

• dotnet run eng/land.cs -- --fixtures tests/fixtures/land: 9 cases, 0 judged wrong. These are land.cs: list the issues a landing closes, and refuse a PR whose declared issue has no closing trailer #209's four, the descriptor's trailer, a malformed line, and three after landing: all closed, one still open, GitHub unreadable.
• The failure path, proven: a pass- case copied as fail-proof.json gave

  FAIL fail-proof.json: lands
  10 cases, 1 judged wrong
  exit 1
  

• A real dry run, dotnet run eng/land.cs -- 253 --print:

  land: the push closes:
    #251 Fleet: a writer whose first open fails never opens again until restart (Started set whatever the outcome) (058e211418db)
  land: the pull request has no `Completes:` line. Add `Completes: #N, ...` naming every issue it completes, or `Completes: none` (#209).
  exit 1
  

• eng/ci.cs with only licence-headers, decision-sets, issue-refs, dco, land-fixtures, release-pending, changelog, release, status and land: all pass.

What was found

• Every pull request open when this lands needs a Completes: line before land.cs will land it. Today that is Fleet: a writer whose first open fails opens again without a restart, and holds off between claims that fail #253, Replication follow-ups: a storage or local-disk release starts the releaser's hold-off, and a move's forward answers by what happened #252, CLI distribution: six attested Native AOT binaries, a keyless Homebrew tap, winget manifests #247, The provider legs by federated credentials: ADR 0223, and auth-providers holds identifiers only (#101, step 2) #242, repo-standard: the declaration catches up with the repository (#101, step 1) #238 and ci(repo-standard): declare the repository About #236. The dependabot pull requests merge without land.cs, so they aren't affected.

What is left

• Issues this touches: land.cs: list the issues a landing closes, and refuse a PR whose declared issue has no closing trailer #209 (completed, Closes #209 trailer) and AGENTS.md: issues are the work log #257 (its bullets now describe the script; AGENTS.md: issues are the work log #257 itself closes with AGENTS.md: issues are the work log; ADR 0241, a commit message never names a model (#257) #259).

---

Checklist

• Issue referenced: Refs #209 on each commit, and Closes #209 on the last.
• ADR cited, or no behaviour was decided: none decided. land.cs: list the issues a landing closes, and refuse a PR whose declared issue has no closing trailer #209 is applied under 0088 and 0102.
• Specification updated, or n/a: n/a.
• API baseline updated, or n/a: n/a.
• Conformance baseline updated, or n/a: n/a.
• Tests: fixtures, through --fixtures, on every eng/ci.cs run.
• A new gate's failure path was proven by running it: quoted above.
• Signed off: by the commit-msg hook.
• A traceability record exists: docs/traceability/2026-11-10-issue-209-closing-trailers-at-landing.md.
• dotnet run eng/ci.cs passes locally: the process gates and fixtures were run; the full test pipeline is left to CI.

---

Generated by Claude Code

[Hafeok]

Head for approval: c7c27e27d8f7d4c6605c1198a522a2e8099d4412. All 34 other checks are green or skipped; the one not green is agent review, which waits on the approval. It lands after #259.

After it lands, every open pull request needs a Completes: line before land.cs will land it. Today that is #253, #252, #247, #242, #238 and #236.

---

Generated by Claude Code

[Hafeok]

approve c7c27e2 (delegate)