Repository navigation
AGENTS.md: issues are the work log; ADR 0241, a commit message never names a model (#257) - #259
Merged
Merged
Conversation
…fier is allowed The maintainer's ruling of 2026-10-27, which #169's gate implements, reverses the commit-message half of ADR 0033's amendment of 2026-10-02. A reversal is a change of meaning, so under ADR 0068 point 2 it is a supersession: ADR 0241 supersedes that one ruling, and ModelNamedInTheRecordNotTheCommit moves to 0241's set under its key, filed unaccepted (ADR 0066). 0033's Status names the supersession, and AGENTS.md (Every commit, Never) and CONTRIBUTING.md state the ruling. The record still names the tool and the model exactly. Refs #257 Refs #169 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Emil Okkels Klein <emil@okkels-klein.dk>
A section after Every commit: work starts from an issue, decisions and blockers go on it when they arise, found work is filed at once, the pull request lists every issue it touches, closings are checked after landing, and abandoned work is closed as not planned. As the prompt's note of 2026-11-10 asks, "the session" in Landing and After landing is whichever session lands: the delegate lands and checks (ADR 0239), and a cloud session posts its head, lists the issues and asks. Refs #257 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Emil Okkels Klein <emil@okkels-klein.dk>
The prompts, the plan's correction from an amendment to ADR 0241's supersession, what changed and what was found (#258). The model is left for the maintainer to fill in, as ADR 0033 provides. Closes #257 Refs #169 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Emil Okkels Klein <emil@okkels-klein.dk>
This was referenced Nov 10, 2026
Closed
Owner
Author
|
Head for approval: Before it lands:
Generated by Claude Code |
This was referenced Nov 11, 2026
Open
Owner
Author
|
approve 3b78886 (delegate) |
Hafeok
added a commit
that referenced
this pull request
Nov 11, 2026
Main is at 2cad18d. This branch is the top of three pull requests that land as one fast-forward: #259 (issues are the work log, ADR 0241), #260 (land.cs checks closing trailers) and #261 (a descriptor's date follows its digests). One file met: docs/adr/README.md, where main had added the section for ADR 0223 and this branch the section for ADR 0241 at the same place. Both are kept, 0223's first. eng/ci.cs merged by itself: main's sdk-pin jobs beside this branch's. Refs #257 Refs #209 Refs #248 Delegated-by: Emil Okkels Klein <emil@okkels-klein.dk> Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Emil Okkels Klein <emil@okkels-klein.dk>
Hafeok
added a commit
that referenced
this pull request
Nov 11, 2026
…entifiers allowed The maintainer read ADR 0241 on #259 and directed it accepted on 2026-11-11. ModelNamedInTheRecordNotTheCommit, as this ADR restates it, gains accepted-by and accepted-at, its statement unchanged, and the ADR's Status line opens Accepted, as eng/release.cs reads it. Written by his delegate at his word (ADR 0239), on the top of the three pull requests that land together. Refs #257 Delegated-by: Emil Okkels Klein <emil@okkels-klein.dk> Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Emil Okkels Klein <emil@okkels-klein.dk>
This was referenced Nov 11, 2026
Open
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes: #257
What this changes, and why
Step 1 of the "issues are the work log" session, for #257, coordinated with #169.
AGENTS.mdgains Issues are the work log, directly after Every commit, word for word as AGENTS.md: issues are the work log #257 proposes, with one added paragraph under Landing: "the session" in Landing and After landing is whichever session lands. The maintainer's delegate lands and checks the closings (ADR 0239); a cloud session posts its head, lists the issues its change touches, and asks.CONTRIBUTING.md, which repeated the old rule.CLAUDE.mdonly points atAGENTS.md.ModelNamedInTheRecordNotTheCommit(ADR 0033's amendment of 2026-10-02). ADR 0068 point 2 makes that a supersession, not an amendment. So 0241 supersedes that one ruling, and the key moves to 0241's set under the same name, with the new statement and noaccepted-by(ADR 0068 point 4). 0033's Status line names the supersession, add-only. The ADR index has an entry. 0240 is taken on another branch.What was measured
dotnet run eng/ci.cswith onlylicence-headers,decision-sets,issue-refs,dco,release-pending,changelog,release,statusandland: all pass.decision-sets: 213 sets, 1,468 decisions, 1,467 accepted. The one unaccepted is 0241's.dotnet build Varve.slnx -c Release: 0 warnings, 0 errors.What was found
ModelNamedInTheRecordNotTheCommit, so its being unaccepted produces noCS0618, and this pull request may not go red on it. It still waits for the maintainer's or his delegate's acceptance (ADR 0066, ADR 0239), and it shouldn't land before that.eng/decision-report/baseline.mdis stale onmain. Regenerating it rewrites about 250 unrelated lines. It doesn't gate, so this change leaves it alone, and eng/decision-report/baseline.md is stale on main #258 tracks it.What is left
accepted-by.AGENTS.mddeliverable is met; its box gets ticked then.Closes #257trailer) and Commit gate: a commit message that names a model fails (names refused, ids allowed) #169 (in part; comment posted).Checklist
Refs #257, and the last carriesCloses #257.docs/traceability/2026-11-10-issue-257-issues-are-the-work-log.md.dotnet run eng/ci.cspasses locally: the process gates and the build were run; the full test pipeline is left to CI.Generated by Claude Code