Adopt a dropped-in update from the mod drawer - #145
Merged
Conversation
Closes #144. Updating a ModHub mod means downloading the new zip into the mods folder over Silo's managed copy (their CDN blocks direct download). Silo already detects the result as a foreign file (flatVersion vs managedVersion) and offers Adopt/Restore — but only via a red error banner and the health panel, so the version never appeared to update and the flow was unclear. The mod's drawer now shows a prominent banner when a foreign build sits in the mods folder: "A newer build is in your mods folder — vX. Silo manages vY. Adopt it…" with Adopt vX / Keep Silo's vY buttons. Adopt promotes the dropped build into the archive (old copy backed up, re-projected if active) and updates the version; the catalog "update available" line is suppressed while the update is already sitting in the folder. resolveForeign is extracted and shared with the health panel. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144.
The flow that wasn't working
Updating a ModHub mod = download the new zip into your mods folder over Silo's managed copy (ModHub's CDN blocks direct download). Silo detected the dropped file as foreign (its
flatVersion≠ the archivedmanagedVersion) and kept showing the old version — the only reconcile path was a scary red error + the health panel. So it looked like the update "didn't take".Fix
The mod's drawer now shows a prominent banner when a foreign build is in the mods folder:
backups/, re-projects if active) and the version updates.resolveForeignis extracted from the health panel and shared, so both entry points do the same thing.Works whether the mod is active (re-projects the new build) or parked (just updates the archive). svelte-check 0/0, build clean. Frontend-only (reuses the existing
adopt_foreign/restore_projectionRust).