Fix Editor target settings for osx-x64 / osx-arm64 native plugins#755
Open
hadashiA wants to merge 1 commit into
Open
Fix Editor target settings for osx-x64 / osx-arm64 native plugins#755hadashiA wants to merge 1 commit into
hadashiA wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the default
NativeRuntimeAssetConfigurationentries forosx-x64andosx-arm64so that native macOS plugins from NuGet packages are importedwith correct Editor compatibility and CPU architecture.
Current vs. expected behavior
When a NuGet package containing macOS native libraries
(
runtimes/osx-x64/native/,runtimes/osx-arm64/native/) is installed:Test plan
Cysharp.NativeCompressions(which ships bothosx-x64andosx-arm64natives in the standardruntimes/<rid>/native/layout)into a fresh project
osx-arm64dylib: Editor enabled, OS = OSX, CPU = ARM64osx-x64dylib: Editor enabled, OS = OSX, CPU = x86_64