Repository navigation
[3/6] Validate functions and reject Promise predicates - #3
Merged
Merged
Conversation
GlenTiki
force-pushed
the
modernize/03-validation
branch
from
October 8, 2026 13:05
46b4467 to
344c142
Compare
GlenTiki
added this pull request to stack #7
October 8, 2026 13:12
GlenTiki
force-pushed
the
modernize/03-validation
branch
from
October 8, 2026 13:13
344c142 to
cd29630
Compare
GlenTiki
force-pushed
the
modernize/03-validation
branch
from
October 8, 2026 13:14
cd29630 to
1ecc049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I validate conditions and callbacks before use, including replacements through the setters. I reject Promise and callable-thenable predicate results instead of treating them as true, and consume their settlement to prevent an additional unhandled rejection.
This is PR 3 of 6 in the modernisation stack. It depends on #2. Review and merge the stack in order.
Polling frequency is left to the next PR.