Skip to content

Pad table: head the first column Pin (#96 follow-up) #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gherkin merged 2 commits into from
Oct 11, 2026
Merged

Pad table: head the first column Pin (#96 follow-up) #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b94c49
Pad table: head the first column "Pin", not "#"
Gherkin Oct 11, 2026
20b3ccd
Pad table test: check the Pin header on an unnamed board too
Gherkin Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/browser/pad-names.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ test('named board: hovering a pad shows its pin name, not its place in the list'
expect(await hover(page, pin1.pos)).toContain('pin ' + pin1.name);

expect(await padTableNumbers(page)).toEqual(fp.pads.map((p) => p.name));
// The first column holds pin names, so its header says so.
expect(await page.locator('#detail-pane .pad-table th').allInnerTexts()).toEqual(['Pin', 'Net', 'Type']);
});

test('unnamed board: hovering a pad still shows pad N', async ({ page }) => {
Expand All @@ -76,6 +78,8 @@ test('unnamed board: hovering a pad still shows pad N', async ({ page }) => {
expect(text).not.toContain('pin 4');

expect(await padTableNumbers(page)).toEqual(fp.pads.map((p, i) => String(i + 1)));
// Same header as on a named board, even though the column holds list places.
expect(await page.locator('#detail-pane .pad-table th').allInnerTexts()).toEqual(['Pin', 'Net', 'Type']);
});

test('the tooltip shows a pad name as text, not markup', async ({ page }) => {
Expand Down
2 changes: 1 addition & 1 deletion web/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ function renderDetailPane(fpIdx, showPads) {
var padTable = document.createElement("table");
padTable.className = "pad-table";
var thead = document.createElement("tr");
["#", "Net", "Type"].forEach(function(h) {
["Pin", "Net", "Type"].forEach(function(h) {
var th = document.createElement("th");
th.textContent = h;
thead.appendChild(th);
Expand Down
Loading