Skip to content

fix(ci): stop the release merge step failing when nothing is released #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GauranshMathur merged 1 commit into from
Oct 1, 2026
Merged

fix(ci): stop the release merge step failing when nothing is released #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,14 @@ jobs:
# to release, as for docs or ci commits.
- name: Merge the release PR
if: ${{ steps.release.outputs.pr }}
# Step env is evaluated even when `if` skips the step, so fromJSON on an
# empty `pr` would fail the job. Parse the PR in the shell instead.
env:
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ fromJSON(steps.release.outputs.pr).number }}
run: gh pr merge "$PR_NUMBER" --squash --repo "$GITHUB_REPOSITORY"
RELEASE_PR: ${{ steps.release.outputs.pr }}
run: |
pr_number="$(jq -r '.number' <<<"$RELEASE_PR")"
gh pr merge "$pr_number" --squash --repo "$GITHUB_REPOSITORY"

# A merge made with GITHUB_TOKEN does not trigger this workflow again, so
# run release-please once more to tag and publish what was just merged.
Expand Down
Loading