Repository navigation
fix(ci): stop the release merge step failing when nothing is released - #23
Merged
Merged
Conversation
The merge step's env ran fromJSON on release-please's pr output, which is empty when a push has nothing to release. That failed the whole job on every docs, ci or chore push to main, even though the step itself was skipped. Pass the raw output through and read the PR number with jq. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CeBtzKd8cVXMuR6go3Ba6n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Arkhaya · project thread
Before: the release-please run for #22 failed with
Error reading JToken from JsonReaderatrelease-please.yml:37. Every push to main with nothing to release (docs, ci, chore) would show a red release run.After: those pushes pass cleanly. A feat, fix or breaking change still gets its release PR opened, merged and tagged in the same run.
How: the merge step's
envranfromJSON(steps.release.outputs.pr), which fails on the empty output even though the step'sifskips it. The step now passes the raw output through and reads the PR number withjqin the shell.Checked: YAML parses,
claude plugin validate . --strictpasses, and the test suite passes (50 tests). The merge path itself will first run on the next feat or fix.🤖 Generated with Claude Code
https://claude.ai/code/session_01CeBtzKd8cVXMuR6go3Ba6n
Generated by Claude Code