Skip to content

wrapper: enable native Mali descriptor folding for Hades II #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
butilly wants to merge 1 commit into
base: wrapper-25
Choose a base branch
from
Open

wrapper: enable native Mali descriptor folding for Hades II #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/vulkan/wrapper/wrapper_physical_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,17 @@ VkResult enumerate_physical_device(struct vk_instance *_instance)
wrapper_core13_wanted(pdevice, instance->vk.app_info.engine_name);
if (pdevice->emulate_vulkan13)
wrapper_core13_init_physical_device(pdevice);
pdevice->fold_sets = pdevice->emulate_vulkan13 &&
/* Hades II also needs eight sets on native Vulkan 1.3 Mali drivers.
* Descriptor folding remaps layouts, bindings and SPIR-V independently
* of core-version emulation; do not require a Vulkan version gap for
* this application. Keep other native-driver applications unchanged.
*/
const char *fold_app = instance->vk.app_info.app_name;
const bool hades2_native_fold = fold_app &&
!strcmp(fold_app, "Hades2.exe") &&
pdevice->driver_properties.driverID == VK_DRIVER_ID_ARM_PROPRIETARY &&
pdevice->properties2.properties.limits.maxBoundDescriptorSets == 7;
pdevice->fold_sets = (pdevice->emulate_vulkan13 || hades2_native_fold) &&
instance->vk.app_info.engine_name &&
strstr(instance->vk.app_info.engine_name, "vkd3d") &&
pdevice->properties2.properties.limits.maxBoundDescriptorSets < 8 &&
Expand Down
Loading