Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game: Hades II; executable: Hades2.exe; thread: 1569125869803405463.
Evidence: the initial report fails in vkd3d_create_pipeline_layout: Root signature requires 8 descriptor sets, but device only supports 7. Latest report retains Mali-G925, wrapper-gamenative, vkd3d 3.0b, and logs Forcing device creation with a NULL pNext chain; no thermal or memory pressure. The latest diagnostic redirects subsequent D3D logging, so the original root-signature failure is the measured target.
The existing wrapper fold implementation remaps descriptor layouts, updates, bindings and SPIR-V but is gated on emulate_vulkan13. Native Vulkan Mali therefore never reaches it. Enable that implementation only for Hades2.exe with the ARM proprietary driver and exactly seven native sets, retaining the vkd3d and kill-switch guards. Do not inflate the underlying hardware limit or change Vulkan core emulation. The current base also masks unsupported requested features before device creation; this patch makes no additional feature-chain change.
Verification: diff check passed; CI compiles and packages the wrapper. On-device acceptance requires the fold activation log, removal of the eight-versus-seven root-signature error, and successful rendering beyond the white screen. Watch for fold-cap truncation or a remaining device-creation failure; neither runtime success nor descriptor-cap sufficiency has been established on this device.