Repository navigation
android: A55 — the cursor rides the daemon's cursor plane - #24
Merged
Merged
Conversation
With GNCL accepted by gamenative-drm, drm_cursor_plane is on: the cursor is scanned out on the daemon's cursor layer, the composite path composites under the cursor plane and re-uses that composite for cursor-only paints, and a cursor motion is a cursor repaint request picked up on the next vblank, so a paint whose only cause is the cursor takes the cursor-only path. An older daemon refuses GNCL and nothing changes.
utkarshdalal
force-pushed
the
cursor-plane-on-android
branch
from
October 31, 2026 12:03
569b7ca to
41aea0e
Compare
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
android: A55 — the cursor rides the daemon's cursor plane
Branch
cursor-plane-on-android(41aea0e), basegamenative(A52 is the last patch there). No longer stacked on #23: A55 applies over 0001-0050 alone. New patchandroid/patches/gamescope/0051-A55-cursor-plane-on-gamenative-drm.patch; the 0001-0051 train applies cleanly over a fresh export. CI build 41199397730.Change
DRMBackend.cpp init_drm: requests the daemon'sGNDRM_CLIENT_CAP_CURSOR_LAYER(0x474E434C, "GNCL"). Accepted ->drm_cursor_planeon, loggeddrm: cursor: daemon cursor layer on (GNCL accepted, max 256x256), drm_cursor_plane=1. Rejected (old daemon) -> unchanged behaviour, logged once.steamcompmgr.cpp: a cursor motion is a repaint request likehasRepaint(picked up on the next vblank, painted on every flip type) but recorded as a cursor repaint, a motion serial the paint records, so a motion during a paint stays pending. A paint whose only cause is the cursor is flagged cursor-only and takes the cursor-only path (same primary framebuffer or the last composite, cursor plane moved, no composite). There is no idle gate ongamenative, so no extra wake is needed.wlserver.cpp:wlserver_oncursoreventuses the cursor repaint when the cursor is on the plane,hasRepaintotherwise.Results (Retroid Pocket 6, 120 Hz, Dave the Diver, cap 60, with gamenative-drm
real-cursor-plane; measured on the earlier build stacked on #23)The remaining ~5 fps drop with the cursor moving is per-motion wineserver work on the game's main thread (not display); separate follow-up.
Needs the daemon PR for the plane to appear; without it (EINVAL) nothing changes.