Repository navigation
Gamescope payload 20261031.3: cursor on its own layer (A55), present-wait shim fix; daemon with the GNCL cursor layer - #2300
Merged
Conversation
…t commit Payload 20261031.2 with bin/gamescope from GameNative/gamescope 8e4b50c (A55, merged #24: the cursor rides the daemon's cursor plane; CI build of the merge commit, run 41202973127) and lib/libadrenotools_gamescope.so from GameNative/gamenative-drm 88e30b2 (#37: the present wait is answered at commit under mailbox/immediate); everything else byte-identical. The daemon (jniLibs libgamenative_drm.so) is rebuilt from gamenative-drm 88e30b2 (#38: the cursor is presented on a layer of its own). sha256 61af3418ae73c0d9116f251756aa8624447369ca61b12e5005a8e80ca3c97ede
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/java/app/gamenative/display/GamescopePayload.kt">
<violation number="1" location="app/src/main/java/app/gamenative/display/GamescopePayload.kt:14">
P1: This version bump makes first launch require `gamescope-gamenative-20261031.3.tzst`, but that archive is not bundled and has not been uploaded. Upload and re-download/verify the required SHA-256 before merging, or keep the version at `20261031.2` until the new archive is available.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| /** Versioned gamescope payload (gamescope, XWayland, scaling clients), fetched on the first gamescope launch. */ | ||
| object GamescopePayload { | ||
| const val VERSION = "20261031.2" | ||
| const val VERSION = "20261031.3" |
Contributor
There was a problem hiding this comment.
P1: This version bump makes first launch require gamescope-gamenative-20261031.3.tzst, but that archive is not bundled and has not been uploaded. Upload and re-download/verify the required SHA-256 before merging, or keep the version at 20261031.2 until the new archive is available.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At app/src/main/java/app/gamenative/display/GamescopePayload.kt, line 14:
<comment>This version bump makes first launch require `gamescope-gamenative-20261031.3.tzst`, but that archive is not bundled and has not been uploaded. Upload and re-download/verify the required SHA-256 before merging, or keep the version at `20261031.2` until the new archive is available.</comment>
<file context>
@@ -11,7 +11,7 @@ import java.io.File
/** Versioned gamescope payload (gamescope, XWayland, scaling clients), fetched on the first gamescope launch. */
object GamescopePayload {
- const val VERSION = "20261031.2"
+ const val VERSION = "20261031.3"
const val ARCHIVE = "gamescope-gamenative-$VERSION.tzst"
private const val STAMP = ".payload.version"
</file context>
Suggested change
| const val VERSION = "20261031.3" | |
| const val VERSION = "20261031.2" |
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Points the app at payload
gamescope-gamenative-20261031.3.tzstand ships the master daemon with the cursor layer.Payload uploaded 2026-10-31 to https://downloads.gamenative.app/gamescope-gamenative-20261031.3.tzst; re-downloaded and verified: sha256
61af3418ae73c0d9116f251756aa8624447369ca61b12e5005a8e80ca3c97ede, 14292251 bytes.The payload is the shipped 20261031.2 with two members replaced, everything else byte-identical (1014 members):
bin/gamescopegamenative@ 8e4b50c, A55 merged as #24: the cursor rides the daemon's cursor plane. CI build of the merge commit (Android build run 41202973127), md51b1beeb07017ed50c8def5341a031793lib/libadrenotools_gamescope.somaster@ 88e30b2, includes #37 (53df34a): the present wait is answered at commit under mailbox/immediate, and replaced frames are answered. md57031c60b0712dd23f73a2126f413e859jniLibs/arm64-v8a/libgamenative_drm.somaster@ 88e30b2, #38: the daemon presents the cursor on a layer of its own (GNCL cursor plane). md540ab00e5cd53bb44aaefca19021ed21aThe daemon and the shim are built from the same gamenative-drm commit (88e30b2) with the testbed's
build-drm-mac.sh; the shim links nolibandroid.so.Verified on the Retroid Pocket 6 (8 Gen 2 / Adreno 740), Dave the Diver:
Dependency: #2299 (drop the
-r 1200vblank grid) is already merged (96cf638).Payload
gamescope-gamenative-20261031.3.tzst, size 14292251, sha25661af3418ae73c0d9116f251756aa8624447369ca61b12e5005a8e80ca3c97ede. Hand-assembled from the merge commits with the testbed repack script, not a packager build.Component SHAs: gamescope 8e4b50cd91e4b0b1aaa99bde1727b28343736af4 (#24), gamenative-drm 88e30b238a42c5666e606b681219b5c7b5d8d219 (#38, on top of #37 53df34aa59e87a747e84ef964d11b5a9929d3114).
Recording
None attached.
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.