Skip to content

Fix: JWT callback allows client-controlled email spoofing via session.update() #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shammy911 merged 2 commits into from
Mar 20, 2026
Merged

Fix: JWT callback allows client-controlled email spoofing via session.update() #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7900d0a
Initial plan
Copilot Mar 20, 2026
466fb52
fix: prevent client-provided email spoofing in JWT callback
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions app/api/auth/[...nextauth]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,11 @@ export const authOptions = {
}

// Apply client-side session.update(...) payload immediately.
// Only allow updating display name — never trust client-provided email.
if (trigger === "update" && session) {
if (typeof session.name === "string") {
token.name = session.name;
}
if (typeof session.email === "string") {
token.email = session.email;
}
}

// 🔥 ALWAYS GET LATEST VALUE FROM DB
Expand All @@ -166,6 +164,17 @@ export const authOptions = {
token.name = admin.name;
token.email = admin.email;
}
} else if (token.userType === "user" && token.id) {
const user = await prisma.user.findUnique({
where: { id: token.id },
select: { email: true },
});

if (user) {
token.email = user.email;
} else {
console.warn(`JWT: no user found for id=${token.id}; token may be stale`);
}
}

return token;
Expand Down
108 changes: 8 additions & 100 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.