Fix: JWT callback allows client-controlled email spoofing via session.update() - #80
Merged
Merged
Conversation
Merged
- Remove token.email = session.email from session.update() handler; client-controlled email was being written directly to the JWT token, enabling session.user.email spoofing. - Add DB re-hydration of token.email for regular users (userType=user) using token.id, consistent with the existing pattern for admin/advisor. - Add a warning log when the user record is not found during re-hydration. Co-authored-by: shammy911 <180457932+shammy911@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from PR #79 for improvements
Fix: JWT callback allows client-controlled email spoofing via session.update()
Mar 20, 2026
shammy911
marked this pull request as ready for review
March 20, 2026 06:17
shammy911
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jwtcallback was applyingsession.update()payloads directly totoken.email, letting any authenticated client overwrite their JWT email — bypassing any downstream authorization or DB lookups that trustsession.user.email.Changes
session.update()handler — onlynameupdates are accepted; email is never taken from client-supplied session payloads.token.emailfrom DB for regular users — on every JWT refresh, email is sourced from the DB via the trustedtoken.id, matching the existing pattern for admin/advisor accounts.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.