Skip to content

Fixed the issue where switching off title slides led to an offset - #177

Open
trekkateer wants to merge 1 commit into
FromEveryLanguage:mainfrom
trekkateer:fix/proclaim-title-slide-offset
Open

trekkateer wants to merge 1 commit into
FromEveryLanguage:mainfrom
trekkateer:fix/proclaim-title-slide-offset

Conversation

@trekkateer

Copy link
Copy Markdown

Also fixed a race condition where if an edit where made on air, the API would indicate a signature change 10 seconds before the SQLite DB got updated, causing new changes to be ignored

…so fixed a race condition where if an edit where made on air, the API would indicate a signature change 10 seconds before the SQLite DB got updated, causing new changes to be ignored
@kcarnold

Copy link
Copy Markdown
Collaborator

Thanks for identifying the race condition. I hadn't really thought about using the revision information, even though it's obviously there. I wonder if we should be using it more thoroughly, e.g., not settling until the revision matches?

Also, I wonder if there's any other part of the Proclaim API we could be using but aren't. For example, does Proclaim give us a total number of slides in each item? If so, we could compare and warn when that number doesn't match what we compute. Then we would have noticed this issue from code rather than observed behavior.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants