Repository navigation
Fixed the issue where switching off title slides led to an offset - #177
Open
trekkateer wants to merge 1 commit into
Open
trekkateer wants to merge 1 commit into
trekkateer wants to merge 1 commit into
Conversation
…so fixed a race condition where if an edit where made on air, the API would indicate a signature change 10 seconds before the SQLite DB got updated, causing new changes to be ignored
Collaborator
|
Thanks for identifying the race condition. I hadn't really thought about using the revision information, even though it's obviously there. I wonder if we should be using it more thoroughly, e.g., not settling until the revision matches? Also, I wonder if there's any other part of the Proclaim API we could be using but aren't. For example, does Proclaim give us a total number of slides in each item? If so, we could compare and warn when that number doesn't match what we compute. Then we would have noticed this issue from code rather than observed behavior. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed a race condition where if an edit where made on air, the API would indicate a signature change 10 seconds before the SQLite DB got updated, causing new changes to be ignored