Repository navigation
Drop activations whose end has passed, even when a refresh cannot reach the tenant - #201
Merged
Merged
Conversation
…ch the tenant A background refresh that cannot renew a sign-in silently keeps the tenant's known rows. After a long sleep those rows outlived their activations and stayed in Active now with a Deactivate button that could only fail. The clock tick now drops active and scheduled rows a minute past their end.
The hint shared the grey info glyph with plain limitations, so a tenant whose rows had gone stale looked fine.
FrodeHus
enabled auto-merge (squash)
September 24, 2026 05:00
FrodeHus
added a commit
that referenced
this pull request
Sep 24, 2026
Port of the macOS fix in #201. ActiveAssignment.HasLapsed in the C# Core; ElevateSession.DropLapsedAssignments, called by 'elevate watch' before every redraw, so a failed re-read no longer leaves ended activations in the table.
FrodeHus
added a commit
that referenced
this pull request
Sep 24, 2026
… warning Port of the macOS change in #201. The hint shared the grey info glyph with plain limitations, so a tenant whose rows had gone stale looked fine; it now shows the warning triangle in the caution colour, and the screen reader says "Sign-in needed".
FrodeHus
added a commit
that referenced
this pull request
Sep 24, 2026
* Core and CLI: drop activations whose end has passed Port of the macOS fix in #201. ActiveAssignment.HasLapsed in the C# Core; ElevateSession.DropLapsedAssignments, called by 'elevate watch' before every redraw, so a failed re-read no longer leaves ended activations in the table. * Windows: drop activations whose end has passed on the clock tick Port of the macOS fix in #201, using ActiveAssignment.HasLapsed from #203. A refresh that cannot read a tenant keeps its known rows; the 30 s clock tick now drops rows a minute past their end, stops their propagation watches and reschedules the toasts. * Windows: show a tenant that needs a sign-in to refresh with a caution warning Port of the macOS change in #201. The hint shared the grey info glyph with plain limitations, so a tenant whose rows had gone stale looked fine; it now shows the warning triangle in the caution colour, and the screen reader says "Sign-in needed". * Changelog: Windows sign-in hint * Windows: use the macOS orange for the sign-in hint Fluent's caution colour turns yellow in dark mode; an app theme brush with the macOS system orange keeps the warning the same on both platforms. * Windows: state what the sign-in hint shows in high contrast On the VM the header glyph renders in the window text colour in high contrast whatever brush is set (a literal magenta did not show), so the entry now names that colour instead of the highlight colour it never displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a long sleep, a loopback (browser sign-in) account could not renew its sign-in silently. The background refresh never prompts, so it kept the tenant's last-known rows — including activations that had already ended. They stayed in Active now with no countdown and a Deactivate button that could only fail, until a manual Refresh signed in again.
The timer itself was fine: the unified log showed refreshes every minute after wake, all succeeding for the other tenants.
Fix
ActiveAssignment.hasLapsed(at:)(Core): active or scheduled rows whose end has passed; requests and failures never lapse.AppModel.dropLapsedAssignments()runs on the 30 s clock tick and drops rows a minute past their end (the grace lets the "expired" notification, due 5 s after the end, fire before the reschedule withdraws it). Independent of whether the refresh can reach the tenant.Tenant header: "Sign-in needed to refresh" now shows an orange warning triangle (was the grey info glyph shared with plain limitations); VoiceOver reads "Sign-in needed".
Tests
LapsedAssignmentTests; Core suite 448 passing; app builds.Not in this PR
refreshAllsays there is one.