Windows: drop activations whose end has passed - #204
Merged
Merged
Conversation
Port of the macOS fix in #201. ActiveAssignment.HasLapsed in the C# Core; ElevateSession.DropLapsedAssignments, called by 'elevate watch' before every redraw, so a failed re-read no longer leaves ended activations in the table.
…s-core-cli # Conflicts: # CHANGELOG.md
… warning Port of the macOS change in #201. The hint shared the grey info glyph with plain limitations, so a tenant whose rows had gone stale looked fine; it now shows the warning triangle in the caution colour, and the screen reader says "Sign-in needed".
Fluent's caution colour turns yellow in dark mode; an app theme brush with the macOS system orange keeps the warning the same on both platforms.
On the VM the header glyph renders in the window text colour in high contrast whatever brush is set (a literal magenta did not show), so the entry now names that colour instead of the highlight colour it never displayed.
…s-windows # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202 (Windows app part; Core and CLI are #203).
Stacked on #203 — it needs
ActiveAssignment.HasLapsedfrom there. Merge #203 first; GitHub then retargets this PR tomain.Change
AppModel.DropLapsedAssignmentsAsync(now)inElevate.App.Model, called from the 30 s clock tick: drops active and scheduled rows a minute past their end (grace so the "expired" toast, due 5 s after the end, is not withdrawn by the reschedule), stops their propagation watches and reschedules the toasts. Same behaviour as the macOS fix in #201.Tests
AppModelLapsedAssignmentTests(drops lapsed rows and keeps live and pending ones; keeps a row inside the one-minute grace).-p:EnableWindowsTargeting=true.Sign-in hint (tenant header)
Port of the macOS change in #201.
PanelGroup.AwaitingSignInturns the issues glyph into the warning triangle in a new app theme brush,ElevateWarningBrush: the macOS system orange (#FF9500light,#FF9F0Adark), so the warning looks the same on both platforms; Fluent's caution colour would turn yellow in dark mode. Errors stay red, plain limitations stay the grey info glyph. Screen reader label "Sign-in needed".Verified on the Windows 11 ARM64 VM: solution and arm64 app build, Core 565 and App 182 tests pass, and a throwaway build forcing the state showed the orange triangle on the account header in both light and dark theme.
High contrast: the glyph renders in the window text colour whatever brush is set (a throwaway build with a literal magenta also showed white), so in high contrast errors, the sign-in hint and limitations differ by glyph shape only, as the platform intends. The theme dictionary's
HighContrastentry names the window text colour so the code matches what shows and the lookup always resolves.