Document _request and add a Dataverse success-path test - #38
Merged
Merged
Conversation
_request now carries the parameters, return value, and error conditions of the Dataverse native-API contract every public method relies on. A new unit test confirms _request returns a non-empty 2xx JSON-object body unchanged, the one behavior no existing test observes directly since every public method discards part of the body.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Documents
DataverseClient._requestand adds a unit test for its success path.Why
The 2xx-bad-body fix rewrote the
_requestreturn contract but left the method undocumented, and the unit tests covered only the empty and malformed body cases, not the branch that decodes and returns a valid body. This closes both gaps.Changes
_requestcovering its parameters, the{}return for an empty 2xx body, and theDataverseErrorconditions (transport failure, status 400 or higher, non-JSON or non-object body).Testing
pytest tests/test_mirror.py: unit tests pass, ruff clean.