Skip to content

Bump the fwl-io floor to 26.8.31 - #841

Open
timlichtenberg wants to merge 1 commit into
mainfrom
tl/bump-fwl-io-pin-26-08-31
Open

timlichtenberg wants to merge 1 commit into
mainfrom
tl/bump-fwl-io-pin-26-08-31

Conversation

@timlichtenberg

Copy link
Copy Markdown
Member

Description

Bump the fwl-io floor from >=26.7.25 to >=26.8.31 so PROTEUS guarantees the fixes released in fwl-io 26.8.31: the Dataverse mirror 2xx-bad-body fix (FormingWorlds/fwl-io#37), the fwl.-prefix logger fix (FormingWorlds/fwl-io#34), and the _request docstring and success-path test (FormingWorlds/fwl-io#38). Release: https://github.com/FormingWorlds/fwl-io/releases/tag/26.08.31 (published on PyPI as 26.8.31, the normalized CalVer form).

The adjacent comment is updated to describe the current pin.

Validation of changes

Confirmed fwl-io 26.8.31 is live on PyPI, and pip install --dry-run "fwl-io>=26.8.31" resolves cleanly in a PROTEUS conda env ("Would install fwl-io-26.8.31", all sub-dependencies already satisfied). macOS with Python 3.12.

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

The mirror upload fix, the logger fix, and the docstring/test updates from
fwl-io#34 only reach my runs once the floor moves past 26.7.25. I confirmed
26.8.31 is live on PyPI and resolves cleanly in the proteus environment.
@timlichtenberg
timlichtenberg requested a review from a team as a code owner August 31, 2026 20:36
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (b06837e) to head (7156d10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files         112      112           
  Lines       16715    16715           
  Branches     2987     2987           
=======================================
+ Hits        15567    15568    +1     
+ Misses       1148     1147    -1     
Flag Coverage Δ
unit-tests 86.74% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

egpbos
egpbos previously approved these changes Sep 1, 2026
@egpbos
egpbos dismissed their stale review September 1, 2026 09:11

Too fast.

@egpbos

egpbos commented Sep 1, 2026

Copy link
Copy Markdown
Member

The tests that are failing trip over a hardcoded specific version string in src/proteus/data/__init__.py, FWL_IO_FLOOR, which is set to the version of fwl-io. The comment notes that this string refers to a schema version. Is that really the case? Is the data schema intended to change with every fwl-io version? If not, a solution would be to separate the schema versioning from the fwl-io versioning. We already have a configuration file version, something similar would make sense for the output as well. I would go for just a single version integer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants