Skip to content

fix: index() -> strchr() - #118

Open
bb010g wants to merge 1 commit into
FillZpp:masterfrom
bb010g:patch-1
Open

fix: index() -> strchr()#118
bb010g wants to merge 1 commit into
FillZpp:masterfrom
bb010g:patch-1

Conversation

@bb010g

@bb010g bb010g commented May 13, 2024

Copy link
Copy Markdown

index() is deprecated.

`index()` is deprecated.
@SamB

SamB commented Nov 5, 2024

Copy link
Copy Markdown

Also, Android's Bionic omits index/rindex altogether: https://cs.android.com/android/platform/superproject/main/+/main:bionic/libc/include/strings.h; there'san implementation of index in ndk_cruft.cpp but I'm not sure what for: it's certainly not exported from libc.so...

@MatiasHiltunen

Copy link
Copy Markdown

This is much needed PR, more about it here: astral-sh/uv#7373 (comment)

@SamB

SamB commented Dec 25, 2024

Copy link
Copy Markdown

Something along the lines of:

[patch.crates-io]
sys-info = { git = "https://github.com/FillZpp/sys-info-rs", rev = "refs/pull/118/head" }

in ~/.cargo/config.toml might help until such time as this gets merged.

I've got the uv tests failing nicely now (seemingly for the same reason as the Termux-provided uv was failing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants