Replace sys-info with sysinfo crate - #17
Conversation
|
The current master branch that this is based on doesn't seem to be able to pass the CI configured: https://github.com/sola-contrib/bugreport/actions/runs/12551564715/job/34996187540 |
|
I made another PR #18 to fix the CI issues, which also bumps the MSRV for the |
|
Thank you! Would you mind rebasing this, so we can compare the outputs in CI with master? |
b01db7f to
d8bad76
Compare
Done! |
The main difference should be that the kernel version is replaced with the OS/distribution version.
I could change this to include the kernel version as well like below: Ok(ReportEntry::List(vec![
ReportEntry::Text(format!(
"OS: {}",
sysinfo::System::long_os_version().unwrap_or_else(|| "Unknown".to_owned()),
)),
ReportEntry::Text(format!(
"Kernel: {}",
sysinfo::System::kernel_version().unwrap_or_else(|| "Unknown".to_owned()),
)),
]))@sharkdp Please let me know your thoughts on the formatting, or any additional information that's available in the |
To save us time from back-and-forth, I pushed an additional commit to add the kernel version information as an option. You can choose whether to include it when applying the patches from this PR. |
|
Thank you very much! |
Closes #16 :
Examples copied from
sysinfo::System::long_os_version's documentation:System::long_os_version()I can add the kernel version information too if someone can give suggestions on how to format them together.
EDIT:
This PR depends on the MSRV bump to 1.74 proposed in #18.merged.A more comprehensive list of outputs is also available in a successful action run based on #18:
https://github.com/sola-contrib/bugreport/actions/runs/12552288110