Repository navigation
perf(install): warm pip install . ~23s -> ~2s (in-tree backend, per-repo target dir) - #1683
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 8 files. (6 skipped: 6 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main performance change for local pip install . and includes relevant implementation context. It does not mention the integration-test consolidation, but the title d… |
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 8 files. (6 skipped: 6 unsupported.)
Full details: Title check
-
Explanation
The title clearly identifies the main performance change for local
pip install .and includes relevant implementation context. It does not mention the integration-test consolidation, but the title does not need to cover every change.
✨ Finishing Touches: 💡 1
-
⚔️ Resolve merge conflicts: 💡
-
- Resolve merge conflict in branch
perf/local-wheel-stored
- Resolve merge conflict in branch
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
… -> ~10s) Warm `pip install .` already skips cargo (staged artifacts up to date), but setuptools deflated ~240 MB of dev-profile binaries at zlib's default level: ~12.5 s to zip plus ~3 s to unzip. The wheel is a throwaway local artifact, so bdist_wheel now uses compression=stored. Release wheels are assembled by ci/publish.py and are unaffected.
zackees
force-pushed
the
perf/local-wheel-stored
branch
from
October 16, 2026 06:57
799979b to
06e2359
Compare
The shared bosn daemon rejects clients from another release, so the exact pin made the gate fail whenever a newer daemon (0.1.22) was running. Use a floor and refresh so the gate always runs the latest bosn.
Replace the setuptools backend with ci/build_backend.py (git mv of setup.py). It has no build requirements (pip's isolated env is empty, no setuptools install), skips the three setup.py subprocesses and the build/ + bdist/ copies of ~240 MB of binaries, and writes the wheel in one stored pass. Editable installs write a plain .pth onto python/, as before. CARGO_TARGET_DIR is now persistent per repo root: ~/.fbuild/cargo-target/wheel-build/<repo>-<sha256(root)[:12]>, so each checkout keeps a stable warm cache and checkouts never thrash each other. Measured on Linux, warm (cargo skipped): pip install . 1.6-2.8 s, uv sync 1.6 s.
zackees
changed the title
zackees
added a commit
that referenced
this pull request
Oct 16, 2026
The pyproject cleanup in #1683 deleted the [build-system] table along with the setuptools sections, so pip fell back to setuptools' default backend and `pip install .` failed with 'Multiple top-level packages discovered'. Verified: cold pip install . (full cargo build) succeeds; warm reinstalls 3.0-5.7 s on a loaded machine; fbuild runs and fbuild._native imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit