Repository navigation
fix(install): restore [build-system] dropped in #1683 - #1685
Merged
Merged
Conversation
The pyproject cleanup in #1683 deleted the [build-system] table along with the setuptools sections, so pip fell back to setuptools' default backend and `pip install .` failed with 'Multiple top-level packages discovered'. Verified: cold pip install . (full cargo build) succeeds; warm reinstalls 3.0-5.7 s on a loaded machine; fbuild runs and fbuild._native imports.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pyproject cleanup in #1683 deleted the [build-system] table along with
the setuptools sections, so pip fell back to setuptools' default backend
and
pip install .failed with 'Multiple top-level packages discovered'.Verified: cold pip install . (full cargo build) succeeds; warm reinstalls
3.0-5.7 s on a loaded machine; fbuild runs and fbuild._native imports.