Repository navigation
fix(serial): clear RTS before DTR at open so attach does not reset ESP chips (#1617) - #1619
Merged
Merged
Conversation
…P chips (#1617) The OS asserts DTR=1/RTS=1 on open. The manager and `serial probe read` then cleared DTR before RTS, passing through (DTR=0, RTS=1) -- the ESP USB-Serial-JTAG "hold in reset" state -- so every attach rebooted the chip. On the ESP32-P4 that reset re-enumerates USB and the session dies with Broken pipe. Add esp_reset::apply_idle_control_lines (RTS first, then DTR) and use it at both manager open sites; reorder serial_probe the same way. Verified on an ESP32-P4: four consecutive `serial probe read` opens with no ESP-ROM banner, ping answers with 850 s uptime (previously every open printed rst:0x17 CHIP_USB_UART_RESET). Closes #1617
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OS asserts DTR=1/RTS=1 on open. The manager and
serial probe readthen cleared DTR before RTS, passing through (DTR=0, RTS=1) -- the ESP
USB-Serial-JTAG "hold in reset" state -- so every attach rebooted the
chip. On the ESP32-P4 that reset re-enumerates USB and the session dies
with Broken pipe.
Add esp_reset::apply_idle_control_lines (RTS first, then DTR) and use it
at both manager open sites; reorder serial_probe the same way.
Verified on an ESP32-P4: four consecutive
serial probe readopens withno ESP-ROM banner, ping answers with 850 s uptime (previously every open
printed rst:0x17 CHIP_USB_UART_RESET).
Closes #1617