Repository navigation
chore(release): bump fbuild to 2.5.31 - #1620
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the workspace and Python package to 2.5.31.
Why now
FastLED's hardware validation on a Linux bench (ESP32-C6, ESP32-P4, RP2350, LPC845) hit three deploy and serial bugs in 2.5.30, now fixed on main:
EBUSY("port is busy"), so every deploy to a device whose verify timed out failed.fbuild serial probe read) cleared DTR before RTS, passing through the USB-Serial-JTAG "hold in reset" state, so each open rebooted ESP chips. On the ESP32-P4 that re-enumerates USB and kills the session (Broken pipeafter ~4 s), so FastLED autoresearch aborted withsession closed.esptoolfrom PATH instead of the esptool the build provisions, sofbuild deployfailed withNo such file or directoryfrom any shell without a Python venv.Release-candidate evidence
Binaries built from the #1618 head (main plus #1615, #1619, #1618; identical code to this bump), run through FastLED's
FBUILD_EXECUTABLEoverride:esptoolon PATH,fbuild <proj> deploy -e esp32c6used the provisioned esptool 5.1.0 and printeddeploy succeeded (full flash). On 2.5.30 it failed to spawnesptool.bash autoresearch esp32c6 --allpassed PARLIO, RMT, SPI and UART (AUTORESEARCH SUCCEEDED).bash autoresearch esp32p4 --allnow gets through pin discovery and runs every test. RMT, SPI and UART pass. PARLIO and LCD_RGB fail on firmware-side issues tracked in ESP32-P4: PARLIO emits nothing and LCD_RGB capture truncates at 256 edges in AutoResearch loopback FastLED#4669. On 2.5.30 the run aborted before any test withsession closed.fbuild serial probe readopens printed no ESP-ROM banner, andpinganswered with 850 s uptime. On 2.5.30 every open printedrst:0x17 (CHIP_USB_UART_RESET).The diff only touches version fields: Cargo.toml, pyproject.toml, 21 workspace entries in Cargo.lock, and uv.lock. No third-party dependency moved.