Repository navigation
fix(deploy): wait for timed-out native espflash ops to release the port (#1614) - #1615
Merged
Merged
Conversation
…rt (#1614) The native verify/write paths ran espflash on spawn_blocking under tokio::time::timeout. A timeout only drops the JoinHandle; the blocking thread keeps running and keeps the serial port open until espflash gives up on its own (~40s past the 30s verify budget on an ESP32-C6). The esptool fallback then failed with EBUSY ("port is busy"). Route all three sites through run_port_bound, which on timeout keeps joining the thread for a bounded release grace so the port is free before the caller falls back, and reports the port as still held if the grace expires. Fixes the comments that claimed the Flasher drops on timeout. Closes #1614
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native verify/write paths ran espflash on spawn_blocking under
tokio::time::timeout. A timeout only drops the JoinHandle; the blocking
thread keeps running and keeps the serial port open until espflash gives
up on its own (~40s past the 30s verify budget on an ESP32-C6). The
esptool fallback then failed with EBUSY ("port is busy").
Route all three sites through run_port_bound, which on timeout keeps
joining the thread for a bounded release grace so the port is free
before the caller falls back, and reports the port as still held if the
grace expires. Fixes the comments that claimed the Flasher drops on
timeout.
Closes #1614