Skip to content

refactor(esp32): take NormalizedPath in Esp32Linker; retire linker-test PathBuf exception (#1512) - #1602

Merged
zackees merged 1 commit into
mainfrom
refactor/1512-esp32-linker-normalized-paths
Sep 30, 2026
Merged

zackees merged 1 commit into
mainfrom
refactor/1512-esp32-linker-normalized-paths

Conversation

@zackees

@zackees zackees commented Sep 30, 2026

Copy link
Copy Markdown
Member

Esp32Linker tool paths and esptool_bin are NormalizedPath; removes the esp32_linker_tests.rs ban_std_pathbuf allowlist entry. The Linker trait and esp32_linker.rs still use PathBuf (file stays allowlisted). Refs #1512.

@zackees zackees added the ci-full Run the complete release-equivalent CI matrix on this PR SHA label Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 42c24719-065b-4a9d-8467-be10a553abbf

📥 Commits

Reviewing files that changed from the base of the PR and between 8196931 and 953d9f2.

📒 Files selected for processing (4)
  • crates/fbuild-build-esp/src/esp32/esp32_linker.rs
  • crates/fbuild-build-esp/src/esp32/esp32_linker_tests.rs
  • crates/fbuild-build-esp/src/esp32/orchestrator/build.rs
  • dylints/ban_std_pathbuf/src/allowlist.txt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees force-pushed the refactor/1512-esp32-linker-normalized-paths branch from 9c9ce0d to 953d9f2 Compare September 30, 2026 09:13
@zackees
zackees merged commit f963848 into main Sep 30, 2026
126 checks passed
@zackees
zackees deleted the refactor/1512-esp32-linker-normalized-paths branch September 30, 2026 09:53
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run the complete release-equivalent CI matrix on this PR SHA

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant