Skip to content

test(compile-db): build fixture path per component so Windows separators match (#1538) - #1603

Merged
zackees merged 1 commit into
mainfrom
fix/compile-db-test-windows-separators
Sep 30, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/compile-db-test-windows-separators

Conversation

@zackees

@zackees zackees commented Sep 30, 2026

Copy link
Copy Markdown
Member

The #1595 test joined lib/gcc with a forward slash, producing mixed separators on Windows while the scanner yields native ones, so translate_for_clang_uses_only_the_entrys_own_toolchain_include_dirs fails on the windows-latest leg (seen on #1602). Test-only fix: join components separately.

@zackees zackees added the ci-full Run the complete release-equivalent CI matrix on this PR SHA label Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fe6dc7a6-caa4-4077-aebd-baa13e855c97

📥 Commits

Reviewing files that changed from the base of the PR and between 449695b and 635857f.

📒 Files selected for processing (1)
  • crates/fbuild-build-engine/src/compile_database/tests/clang.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 8196931 into main Sep 30, 2026
130 of 135 checks passed
@zackees
zackees deleted the fix/compile-db-test-windows-separators branch September 30, 2026 09:13
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run the complete release-equivalent CI matrix on this PR SHA

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant