Skip to content

fix(ci): restore portable Dylint and integration-test checks - #1523

Closed
zackees wants to merge 2 commits into
mainfrom
fix/dylint-portable-touch
Closed

zackees wants to merge 2 commits into
mainfrom
fix/dylint-portable-touch

Conversation

@zackees

@zackees zackees commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Problems

  • The Dylint cache-preservation step from Fix Dylint test path checks and preserve dependency cache #1522 calls rg, but macOS and Windows runners do not have ripgrep installed. Those jobs fail before scanning.
  • The same change used option_env! followed by expect in integration tests. Clippy denies that pattern under -D warnings, failing the Linux check.

Fix

  • Use POSIX find with batched touch to refresh Rust sources without requiring rg or GNU xargs -r. This keeps dependency cache reuse.
  • Read Cargo test binary paths at runtime, which also compiles under Dylint all-targets checks without the Clippy option_env_unwrap lint.

Validation

  • On Linux, old and new selectors both find the same 558 Rust files under crates.
  • Focused fbuild CLI integration tests pass 6/6 using runtime binary paths.
  • Clippy for fbuild-cli and fbuild-daemon all targets passes with -D warnings; formatting and diff checks pass.
  • Linux and macOS Dylint passed on the first commit; Windows was still running when the test-path fix was pushed. The new CI run is the final acceptance gate.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b6b608d8-748d-4efa-826e-2d5c2427a459

📥 Commits

Reviewing files that changed from the base of the PR and between cf1724e and 3dd26dc.

📒 Files selected for processing (8)
  • .github/workflows/dylint.yml
  • crates/fbuild-cli/tests/ci_command.rs
  • crates/fbuild-cli/tests/daemon_crash_recovery.rs
  • crates/fbuild-cli/tests/lib_select.rs
  • crates/fbuild-cli/tests/test_emu_exit_code.rs
  • crates/fbuild-daemon/tests/legacy_daemon_transition.rs
  • crates/fbuild-daemon/tests/port_recovery.rs
  • crates/fbuild-daemon/tests/process_containment.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees zackees changed the title fix(ci): refresh Dylint sources without ripgrep fix(ci): restore portable Dylint and integration-test checks Sep 27, 2026
@zackees

zackees commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

Superseded by merged #1524: main now has the portable find-based Dylint scan and runtime CARGO_BIN_EXE lookups from this PR. #1524 intentionally replaced the three-OS Dylint matrix with the fast Linux gate, so rebasing this PR would reintroduce the removed slow jobs. Closing rather than merging the conflicting, obsolete workflow.

@zackees zackees closed this Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant